Patchwork [1/1] mxc_nand : add RESET command support

login
register
mail settings
Submitter Eric Benard
Date Dec. 9, 2009, 11:12 a.m.
Message ID <1260357163-5367-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/40721/
State Accepted
Commit 66803762c19f2e45ff4cc13cf63194589eb698c2
Headers show

Comments

Eric Benard - Dec. 9, 2009, 11:12 a.m.
mxc_nand driver must support the RESET Command in order to support
Micron NAND which need a reset before any other command.

Signed-off-by: Eric Benard <eric@eukrea.com>
---
 drivers/mtd/nand/mxc_nand.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Sascha Hauer - Dec. 11, 2009, 12:40 p.m.
On Wed, Dec 09, 2009 at 12:12:43PM +0100, Eric Benard wrote:
> mxc_nand driver must support the RESET Command in order to support
> Micron NAND which need a reset before any other command.
> 
> Signed-off-by: Eric Benard <eric@eukrea.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  drivers/mtd/nand/mxc_nand.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index d5445cd..0207525 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -638,6 +638,7 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
>  
>  	case NAND_CMD_ERASE1:
>  	case NAND_CMD_ERASE2:
> +	case NAND_CMD_RESET:
>  		send_cmd(host, command, false);
>  		mxc_do_addr_cycle(mtd, column, page_addr);
>  
> -- 
> 1.6.3.3
> 
> 
>
Sascha Hauer - Jan. 22, 2010, 8:12 a.m.
Artem, can you take this patch, please?

If your ok with it, I could take patches only affecting the mxc_nand
driver also via my i.MX tree.

Sascha

On Wed, Dec 09, 2009 at 12:12:43PM +0100, Eric Benard wrote:
> mxc_nand driver must support the RESET Command in order to support
> Micron NAND which need a reset before any other command.
> 
> Signed-off-by: Eric Benard <eric@eukrea.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  drivers/mtd/nand/mxc_nand.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index d5445cd..0207525 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -638,6 +638,7 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
>  
>  	case NAND_CMD_ERASE1:
>  	case NAND_CMD_ERASE2:
> +	case NAND_CMD_RESET:
>  		send_cmd(host, command, false);
>  		mxc_do_addr_cycle(mtd, column, page_addr);
>  
> -- 
> 1.6.3.3
> 
> 
>
Artem Bityutskiy - Feb. 3, 2010, 4:02 p.m.
On Fri, 2010-01-22 at 09:12 +0100, Sascha Hauer wrote:
> Artem, can you take this patch, please?
> 
> If your ok with it, I could take patches only affecting the mxc_nand
> driver also via my i.MX tree.

Yeah, it is  sitting in my l2-mtd-2.6 / dunno

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index d5445cd..0207525 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -638,6 +638,7 @@  static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
 
 	case NAND_CMD_ERASE1:
 	case NAND_CMD_ERASE2:
+	case NAND_CMD_RESET:
 		send_cmd(host, command, false);
 		mxc_do_addr_cycle(mtd, column, page_addr);