diff mbox

autobuild-run: Do not build civetweb with this external MIPS toolchain

Message ID 1415194566-60867-1-git-send-email-Vincent.Riera@imgtec.com
State Accepted
Headers show

Commit Message

Vicente Olivert Riera Nov. 5, 2014, 1:36 p.m. UTC
This MIPS uClibc toolchain doesn't have the needed fix in order to build
the civetweb package statically for uClibc. It fails with messages like
these ones:

libdl.c:(.text+0x1840): undefined reference to `TLS_DTPREL_VALUE'
libdl.c:(.text+0x1884): undefined reference to `TLS_TPREL_VALUE'

This has been already fixed in Buildroot, but this toolchain was
generated before.

Related:
  http://lists.uclibc.org/pipermail/uclibc/2013-April/047708.html
  http://git.buildroot.net/buildroot/commit/?id=c0b4c45780e4ffe23101a407e7c4cde22e27815a

Fixes:
  http://autobuild.buildroot.net/results/4a1/4a179bebdc9cd85780d7f16f672ee019a1947147/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 scripts/autobuild-run |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Nov. 6, 2014, 7:32 a.m. UTC | #1
Dear Vicente Olivert Riera,

On Wed, 5 Nov 2014 13:36:06 +0000, Vicente Olivert Riera wrote:

> This has been already fixed in Buildroot, but this toolchain was
> generated before.

The toolchain you are excluding as *not* been generated by Buildroot,
but by Crosstool-NG, as the "ctng" part of the tarball name suggests.

So, I'm fine with the change, but not really with the commit log :-)

Thanks,

Thomas
diff mbox

Patch

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 40291ce..13752f9 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -298,6 +298,10 @@  def fixup_config(instance, sysinfo):
     if 'BR2_PACKAGE_RT_TESTS=y\n' in configlines and \
        'BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/mipsel-ctng-linux-uclibc.tar.xz"\n' in configlines:
         return False
+    # This MIPS uClibc toolchain fails to build the civetweb package
+    if 'BR2_PACKAGE_CIVETWEB=y\n' in configlines and \
+       'BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/mipsel-ctng-linux-uclibc.tar.xz"\n' in configlines:
+        return False
     # This MIPS ctng toolchain fails to build the python3 package
     if 'BR2_PACKAGE_PYTHON3=y\n' in configlines and \
        'BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/mips64el-ctng_n64-linux-gnu.tar.xz"\n' in configlines: