diff mbox

[RFC,12/12] ixgbevf: Kconfig, Makefile and Documentation

Message ID 20091208221652.28373.22254.stgit@localhost.localdomain
State RFC, archived
Delegated to: David Miller
Headers show

Commit Message

Kirsher, Jeffrey T Dec. 8, 2009, 10:16 p.m. UTC
From: Greg Rose <gregory.v.rose@intel.com>

Modifications for the Kconfig and network device Makefile to add the ixgbevf
driver module to the kernel and documentation.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 Documentation/networking/ixgbevf.txt |   94 ++++++++++++++++++++++++++++++++++
 drivers/net/Kconfig                  |   21 ++++++++
 drivers/net/Makefile                 |    1 
 3 files changed, 116 insertions(+), 0 deletions(-)
 create mode 100755 Documentation/networking/ixgbevf.txt


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Randy Dunlap Dec. 8, 2009, 10:41 p.m. UTC | #1
On Tue, 08 Dec 2009 14:16:53 -0800 Jeff Kirsher wrote:

> From: Greg Rose <gregory.v.rose@intel.com>
> 
> Modifications for the Kconfig and network device Makefile to add the ixgbevf
> driver module to the kernel and documentation.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> 
>  Documentation/networking/ixgbevf.txt |   94 ++++++++++++++++++++++++++++++++++
>  drivers/net/Kconfig                  |   21 ++++++++
>  drivers/net/Makefile                 |    1 
>  3 files changed, 116 insertions(+), 0 deletions(-)
>  create mode 100755 Documentation/networking/ixgbevf.txt
> 
> diff --git a/Documentation/networking/ixgbevf.txt b/Documentation/networking/ixgbevf.txt
> new file mode 100755
> index 0000000..4981426
> --- /dev/null
> +++ b/Documentation/networking/ixgbevf.txt

> +The ixgbevf driver supports 82599-based virtual function devices that can only
> +be activated on kernels with CONFIG_PCI_IOV enabled.
> +
> +The guest OS loading the ixgbevf driver must support MSI-X interrupts.

Hi,

Could the Kconfig language express some of these requirements, or
am I confused between the host and the guest OS?


> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 0bbd5ae..a484415 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2614,6 +2614,27 @@ config IXGBE_DCB
>  
>  	  If unsure, say N.
>  
> +config IXGBEVF
> +       tristate "Intel(R) 82599 Virtual Function Ethernet support"
> +       depends on PCI

	depends on PCI_IOV && PCI_MSI
??


> +       ---help---
> +         This driver supports Intel(R) 82599 virtual functions.  For more
> +         information on how to identify your adapter, go to the Adapter &
> +         Driver ID Guide at:
> +
> +         <http://support.intel.com/support/network/adapter/pro100/21397.htm>
> +
> +         For general information and support, go to the Intel support
> +         website at:
> +
> +         <http://support.intel.com>
> +
> +         More specific information on configuring the driver is in
> +         <file:Documentation/networking/ixgbe.txt>.
> +
> +         To compile this driver as a module, choose M here. The module
> +         will be called ixgbevf.
> +


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rose, Gregory V Dec. 8, 2009, 10:49 p.m. UTC | #2
>-----Original Message-----
>From: Randy Dunlap [mailto:randy.dunlap@oracle.com]
>Sent: Tuesday, December 08, 2009 2:42 PM
>To: Kirsher, Jeffrey T
>Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V
>Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and
>Documentation
>
>> +The ixgbevf driver supports 82599-based virtual function devices that
>can only
>> +be activated on kernels with CONFIG_PCI_IOV enabled.
>> +
>> +The guest OS loading the ixgbevf driver must support MSI-X
>interrupts.
>
>Hi,
>
>Could the Kconfig language express some of these requirements, or
>am I confused between the host and the guest OS?
[Rose, Gregory V] 

The guest OS must also support MSI-X interrupts.  It is a requirement of our VF device to use MSI-X.

>
>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 0bbd5ae..a484415 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -2614,6 +2614,27 @@ config IXGBE_DCB
>>
>>  	  If unsure, say N.
>>
>> +config IXGBEVF
>> +       tristate "Intel(R) 82599 Virtual Function Ethernet support"
>> +       depends on PCI
>
>	depends on PCI_IOV && PCI_MSI
>??
>
[Rose, Gregory V] 

The guest does not need to have IOV support configured to use the VF device but it does need MSI-X.  We'll incorporate this suggested change.

Thanks for your comments.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Dec. 10, 2009, 12:59 a.m. UTC | #3
On Tue, Dec 08, 2009 at 02:49:21PM -0800, Rose, Gregory V wrote:
> >-----Original Message-----
> >From: Randy Dunlap [mailto:randy.dunlap@oracle.com]
> >Sent: Tuesday, December 08, 2009 2:42 PM
> >To: Kirsher, Jeffrey T
> >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V
> >Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and
> >Documentation
> >
> >> +The ixgbevf driver supports 82599-based virtual function devices that
> >can only
> >> +be activated on kernels with CONFIG_PCI_IOV enabled.
> >> +
> >> +The guest OS loading the ixgbevf driver must support MSI-X
> >interrupts.
> >
> >Hi,
> >
> >Could the Kconfig language express some of these requirements, or
> >am I confused between the host and the guest OS?
> [Rose, Gregory V] 
> 
> The guest OS must also support MSI-X interrupts.  It is a requirement of our VF device to use MSI-X.
> 
> >
> >
> >> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> >> index 0bbd5ae..a484415 100644
> >> --- a/drivers/net/Kconfig
> >> +++ b/drivers/net/Kconfig
> >> @@ -2614,6 +2614,27 @@ config IXGBE_DCB
> >>
> >>  	  If unsure, say N.
> >>
> >> +config IXGBEVF
> >> +       tristate "Intel(R) 82599 Virtual Function Ethernet support"
> >> +       depends on PCI
> >
> >	depends on PCI_IOV && PCI_MSI
> >??
> >
> [Rose, Gregory V] 
> 
> The guest does not need to have IOV support configured to use the VF device but it does need MSI-X.  We'll incorporate this suggested change.
> 
> Thanks for your comments.

The igbvf driver can also run on the host or indeed on a system
without virtualisation. Is the same true of the ixgbevf driver?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rose, Gregory V Dec. 10, 2009, 1:04 a.m. UTC | #4
>-----Original Message-----
>From: Simon Horman [mailto:horms@verge.net.au]
>Sent: Wednesday, December 09, 2009 5:00 PM
>To: Rose, Gregory V
>Cc: Randy Dunlap; Kirsher, Jeffrey T; netdev@vger.kernel.org;
>gospo@redhat.com
>Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and
>Documentation
>

>The igbvf driver can also run on the host or indeed on a system
>without virtualisation. Is the same true of the ixgbevf driver?

[Rose, Gregory V] 

Yes.

- Greg
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/networking/ixgbevf.txt b/Documentation/networking/ixgbevf.txt
new file mode 100755
index 0000000..4981426
--- /dev/null
+++ b/Documentation/networking/ixgbevf.txt
@@ -0,0 +1,94 @@ 
+Linux* Base Driver for Intel(R) Network Connection
+==================================================
+
+November 24, 2009
+
+Contents
+========
+
+- In This Release
+- Identifying Your Adapter
+- Known Issues/Troubleshooting
+- Support
+
+In This Release
+===============
+
+This file describes the ixgbevf Linux* Base Driver for Intel Network
+Connection.
+
+The ixgbevf driver supports 82599-based virtual function devices that can only
+be activated on kernels with CONFIG_PCI_IOV enabled.
+
+The ixgbevf driver supports virtual functions generated by the ixgbe driver
+with a max_vfs value of 1 or greater.
+
+The guest OS loading the ixgbevf driver must support MSI-X interrupts.
+
+VLANs: There is a limit of a total of 32 shared VLANs to 1 or more VFs.
+
+Identifying Your Adapter
+========================
+
+For more information on how to identify your adapter, go to the Adapter &
+Driver ID Guide at:
+
+    http://support.intel.com/support/go/network/adapter/idguide.htm
+
+Known Issues/Troubleshooting
+============================
+
+  Intel(R) Active Management Technology 2.0, 2.1, 2.5 not supported in
+  conjunction with Linux driver
+  ---------------------------------------------------------------------
+
+  Unloading Physical Function (PF) Driver Causes System Reboots When VM is
+  Running and VF is Loaded on the VM
+  ------------------------------------------------------------------------
+  Do not unload the PF driver (ixgbe) while VFs are assigned to guests.
+
+Support
+=======
+
+For general information, go to the Intel support website at:
+
+    http://support.intel.com
+
+or the Intel Wired Networking project hosted by Sourceforge at:
+
+    http://sourceforge.net/projects/e1000
+
+If an issue is identified with the released source code on the supported
+kernel with a supported adapter, email the specific information related
+to the issue to ixgbevf-devel@lists.sf.net
+
+License
+=======
+
+Intel Gigabit Linux driver.
+Copyright(c) 1999 - 2008 Intel Corporation.
+
+This program is free software; you can redistribute it and/or modify it
+under the terms and conditions of the GNU General Public License,
+version 2, as published by the Free Software Foundation.
+
+This program is distributed in the hope it will be useful, but WITHOUT
+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+more details.
+
+You should have received a copy of the GNU General Public License along with
+this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+
+The full GNU General Public License is included in this distribution in
+the file called "COPYING".
+
+Trademarks
+==========
+
+Intel, Itanium, and Pentium are trademarks or registered trademarks of
+Intel Corporation or its subsidiaries in the United States and other
+countries.
+
+* Other names and brands may be claimed as the property of others.
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 0bbd5ae..a484415 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2614,6 +2614,27 @@  config IXGBE_DCB
 
 	  If unsure, say N.
 
+config IXGBEVF
+       tristate "Intel(R) 82599 Virtual Function Ethernet support"
+       depends on PCI
+       ---help---
+         This driver supports Intel(R) 82599 virtual functions.  For more
+         information on how to identify your adapter, go to the Adapter &
+         Driver ID Guide at:
+
+         <http://support.intel.com/support/network/adapter/pro100/21397.htm>
+
+         For general information and support, go to the Intel support
+         website at:
+
+         <http://support.intel.com>
+
+         More specific information on configuring the driver is in
+         <file:Documentation/networking/ixgbe.txt>.
+
+         To compile this driver as a module, choose M here. The module
+         will be called ixgbevf.
+
 config IXGB
 	tristate "Intel(R) PRO/10GbE support"
 	depends on PCI
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 246323d..da7658b 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -14,6 +14,7 @@  obj-$(CONFIG_IBM_NEW_EMAC) += ibm_newemac/
 obj-$(CONFIG_IGB) += igb/
 obj-$(CONFIG_IGBVF) += igbvf/
 obj-$(CONFIG_IXGBE) += ixgbe/
+obj-$(CONFIG_IXGBEVF) += ixgbevf/
 obj-$(CONFIG_IXGB) += ixgb/
 obj-$(CONFIG_IP1000) += ipg.o
 obj-$(CONFIG_CHELSIO_T1) += chelsio/