diff mbox

[U-Boot] common.h: Add prototype of arch_preboot_os

Message ID 1415085249-31363-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com
State Not Applicable
Delegated to: Tom Rini
Headers show

Commit Message

Nobuhiro Iwamatsu Nov. 4, 2014, 7:14 a.m. UTC
When we used arch_preboot_os() function because prototype of this is not
declared, following warning is output.

-----
warning: function declaration isn't a prototype [-Wstrict-prototypes]
-----

This adds prototype of arch_preboot_os() to include/common.h.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 include/common.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Igor Grinberg Nov. 4, 2014, 7:50 a.m. UTC | #1
On 11/04/14 09:14, Nobuhiro Iwamatsu wrote:
> When we used arch_preboot_os() function because prototype of this is not
> declared, following warning is output.

Or.. you just need to include the correct file:

$ grep -nr arch_preboot_os include/
include/bootm.h:57:void arch_preboot_os(void);

> 
> -----
> warning: function declaration isn't a prototype [-Wstrict-prototypes]
> -----
> 
> This adds prototype of arch_preboot_os() to include/common.h.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  include/common.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/common.h b/include/common.h
> index d5020c8..8ee9ca5 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -318,6 +318,9 @@ void board_show_dram(ulong size);
>   */
>  int arch_fixup_fdt(void *blob);
>  
> +/* Set arch specific config before boot */
> +void arch_preboot_os(void);
> +
>  /* common/flash.c */
>  void flash_perror (int);
>  
>
Nobuhiro Iwamatsu Nov. 4, 2014, 10 p.m. UTC | #2
Hi!

2014-11-04 16:50 GMT+09:00 Igor Grinberg <grinberg@compulab.co.il>:
> On 11/04/14 09:14, Nobuhiro Iwamatsu wrote:
>> When we used arch_preboot_os() function because prototype of this is not
>> declared, following warning is output.
>
> Or.. you just need to include the correct file:
>
> $ grep -nr arch_preboot_os include/
> include/bootm.h:57:void arch_preboot_os(void);

Oh, I see.
Thanks for your check.

Best regards,
  Nobuhiro
diff mbox

Patch

diff --git a/include/common.h b/include/common.h
index d5020c8..8ee9ca5 100644
--- a/include/common.h
+++ b/include/common.h
@@ -318,6 +318,9 @@  void board_show_dram(ulong size);
  */
 int arch_fixup_fdt(void *blob);
 
+/* Set arch specific config before boot */
+void arch_preboot_os(void);
+
 /* common/flash.c */
 void flash_perror (int);