| Message ID | 1414855820-15094-2-git-send-email-ezequiel.garcia@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Dear Ezequiel Garcia, On Sat, 1 Nov 2014 12:30:20 -0300, Ezequiel Garcia wrote: > Data corruption has been observed to be produced by TSO. For instance, > accessing files on a NFS-server with TSO enabled results in different data > transferred each time. > > This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth > driver. Same tests on platforms using the mvneta ethernet driver have > passed without errors. > > Make TSO disabled by default for now, until we can found a proper fix > for the regression. > > Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO') > Reported-by: Slawomir Gajzner <slawomir.gajzner@gmail.com> > Reported-by: Julien D'Ascenzio <jdascenzio@yahoo.fr> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Shouldn't you have a: Cc: <stable@vger.kernel.org> # v3.16+ here ? Thanks, Thomas
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Date: Sat, 1 Nov 2014 18:00:37 +0100 > Dear Ezequiel Garcia, > > On Sat, 1 Nov 2014 12:30:20 -0300, Ezequiel Garcia wrote: >> Data corruption has been observed to be produced by TSO. For instance, >> accessing files on a NFS-server with TSO enabled results in different data >> transferred each time. >> >> This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth >> driver. Same tests on platforms using the mvneta ethernet driver have >> passed without errors. >> >> Make TSO disabled by default for now, until we can found a proper fix >> for the regression. >> >> Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO') >> Reported-by: Slawomir Gajzner <slawomir.gajzner@gmail.com> >> Reported-by: Julien D'Ascenzio <jdascenzio@yahoo.fr> >> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > > Shouldn't you have a: > > Cc: <stable@vger.kernel.org> # v3.16+ Networking patches do not get sent to -stable that way. Instead, people specifically request that I queue up the change for -stable and I submit it by hand at the appropriate time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index b151a94..8b72780 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -3110,11 +3110,11 @@ static int mv643xx_eth_probe(struct platform_device *pdev) dev->watchdog_timeo = 2 * HZ; dev->base_addr = 0; - dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO; + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM; dev->vlan_features = dev->features; dev->features |= NETIF_F_RXCSUM; - dev->hw_features = dev->features; + dev->hw_features = dev->features | NETIF_F_TSO; dev->priv_flags |= IFF_UNICAST_FLT; dev->gso_max_segs = MV643XX_MAX_TSO_SEGS;
Data corruption has been observed to be produced by TSO. For instance, accessing files on a NFS-server with TSO enabled results in different data transferred each time. This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth driver. Same tests on platforms using the mvneta ethernet driver have passed without errors. Make TSO disabled by default for now, until we can found a proper fix for the regression. Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO') Reported-by: Slawomir Gajzner <slawomir.gajzner@gmail.com> Reported-by: Julien D'Ascenzio <jdascenzio@yahoo.fr> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/net/ethernet/marvell/mv643xx_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)