Message ID | 1414800623-7721-1-git-send-email-jkrause@posteo.de |
---|---|
State | Superseded |
Headers | show |
>>>>> "Jörg" == Jörg Krause <jkrause@posteo.de> writes: > Some packages needs libavahi-client support which is autobuild by avahi if > avahi-daemon and dbus is selected. To select libavahi-client explicitly makes > this dependency more obvious for dependent packages. > libdns_sd is only build by avahi if libavahi-client is present (and > `--enable-compat-libdns_sd` is set as configure option). So it's safe to > depend on libavahi-client instead of avahi-daemon. Having a user visible option for this is a bit odd as it cannot be used to DISABLE the library. Perhaps it should just be a hidden helper option for other packages instead? (so drop the bool and help text) > Signed-off-by: Jörg Krause <jkrause@posteo.de> > --- > package/avahi/Config.in | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > diff --git a/package/avahi/Config.in b/package/avahi/Config.in > index b52cc78..56b372e 100644 > --- a/package/avahi/Config.in > +++ b/package/avahi/Config.in > @@ -35,11 +35,17 @@ config BR2_PACKAGE_AVAHI_DAEMON > The daemon registers local IP addresses and services using > mDNS/DNS-SD. > -config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY > - bool "libdns_sd compatibility (Bonjour)" > +config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT > + bool "libavahi-client" > depends on BR2_PACKAGE_AVAHI_DAEMON > select BR2_PACKAGE_DBUS > help > + Enable the Avahi client library. > + > +config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY > + bool "libdns_sd compatibility (Bonjour)" > + depends on BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT > + help > Enable the libdns_sd (Bonjour) compatibility library support > for legacy applications. > -- > 2.1.3 > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Peter, All, On So, 2014-11-02 at 23:51 +0100, Peter Korsgaard wrote: > >>>>> "Jörg" == Jörg Krause <jkrause@posteo.de> writes: > > > Some packages needs libavahi-client support which is autobuild by avahi if > > avahi-daemon and dbus is selected. To select libavahi-client explicitly makes > > this dependency more obvious for dependent packages. > > > libdns_sd is only build by avahi if libavahi-client is present (and > > `--enable-compat-libdns_sd` is set as configure option). So it's safe to > > depend on libavahi-client instead of avahi-daemon. > > Having a user visible option for this is a bit odd as it cannot be used > to DISABLE the library. > > Perhaps it should just be a hidden helper option for other packages > instead? (so drop the bool and help text) I agree with you. I want to check for libavahi-client in shairport-sync.mk without adding a user prompt in Config.in: ifeq ($(BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT),y) SHAIRPORT_SYNC_DEPENDENCIES += avahi SHAIRPORT_SYNC_CONF_OPTS += --with-avahi else SHAIRPORT_SYNC_CONF_OPTS += --with-tinysvcmdns endif Does it make sense to have a hidden config symbol which is both selectable and checkable. This is what I have in mind: config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT bool default y if (BR2_PACKAGE_AVAHI_DAEMON && BR2_PACKAGE_DBUS) depends on BR2_PACKAGE_AVAHI_DAEMON select BR2_PACKAGE_DBUS # selected in package A select BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT # checked in package B ifeq ($(BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT),y) Best regards Jörg
diff --git a/package/avahi/Config.in b/package/avahi/Config.in index b52cc78..56b372e 100644 --- a/package/avahi/Config.in +++ b/package/avahi/Config.in @@ -35,11 +35,17 @@ config BR2_PACKAGE_AVAHI_DAEMON The daemon registers local IP addresses and services using mDNS/DNS-SD. -config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY - bool "libdns_sd compatibility (Bonjour)" +config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT + bool "libavahi-client" depends on BR2_PACKAGE_AVAHI_DAEMON select BR2_PACKAGE_DBUS help + Enable the Avahi client library. + +config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY + bool "libdns_sd compatibility (Bonjour)" + depends on BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT + help Enable the libdns_sd (Bonjour) compatibility library support for legacy applications.
Some packages needs libavahi-client support which is autobuild by avahi if avahi-daemon and dbus is selected. To select libavahi-client explicitly makes this dependency more obvious for dependent packages. libdns_sd is only build by avahi if libavahi-client is present (and `--enable-compat-libdns_sd` is set as configure option). So it's safe to depend on libavahi-client instead of avahi-daemon. Signed-off-by: Jörg Krause <jkrause@posteo.de> --- package/avahi/Config.in | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)