Patchwork [FOR,0.12,12/18] QError: New QERR_FD_NOT_FOUND

login
register
mail settings
Submitter Markus Armbruster
Date Dec. 7, 2009, 8:37 p.m.
Message ID <1260218236-22143-13-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/40530/
State New
Headers show

Comments

Markus Armbruster - Dec. 7, 2009, 8:37 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qerror.c |    4 ++++
 qerror.h |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)
Luiz Capitulino - Dec. 8, 2009, 11:51 a.m.
On Mon,  7 Dec 2009 21:37:10 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> +#define QERR_FD_NOT_FOUND \
> +    "{ 'class': 'fd_not_found', 'data': { 'name': %s } }"
> +

 I think this came from your previous series of not using CamelCase?

 Also happens in next patches..
Markus Armbruster - Dec. 8, 2009, 12:25 p.m.
Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Mon,  7 Dec 2009 21:37:10 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> +#define QERR_FD_NOT_FOUND \
>> +    "{ 'class': 'fd_not_found', 'data': { 'name': %s } }"
>> +
>
>  I think this came from your previous series of not using CamelCase?
>
>  Also happens in next patches..

Rats.  Fixing...

Patch

diff --git a/qerror.c b/qerror.c
index 128a91e..d75c69a 100644
--- a/qerror.c
+++ b/qerror.c
@@ -65,6 +65,10 @@  static const QErrorStringTable qerror_table[] = {
         .desc      = "Device %(device) is not removable",
     },
     {
+        .error_fmt = QERR_FD_NOT_FOUND,
+        .desc      = "Failed to find file descriptor named %(name)",
+    },
+    {
         .error_fmt = QERR_INVALID_BLOCK_FORMAT,
         .desc      = "Invalid block format %(name)",
     },
diff --git a/qerror.h b/qerror.h
index 1a05d9a..bda764f 100644
--- a/qerror.h
+++ b/qerror.h
@@ -56,6 +56,9 @@  QError *qobject_to_qerror(const QObject *obj);
 #define QERR_DEVICE_NOT_REMOVABLE \
     "{ 'class': 'DeviceNotRemovable', 'data': { 'device': %s } }"
 
+#define QERR_FD_NOT_FOUND \
+    "{ 'class': 'fd_not_found', 'data': { 'name': %s } }"
+
 #define QERR_INVALID_BLOCK_FORMAT \
     "{ 'class': 'InvalidBlockFormat', 'data': { 'name': %s } }"