| Message ID | 1414748366-3208-1-git-send-email-hs@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
Hi Heiko, On 31.10.2014 10:39, Heiko Schocher wrote: > ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" > introduced the writebufsize field in struct mtd_info, which > is not initialized in the cfi_flash driver, which leads in > not working ubi on cfi flashes. Fix it > > Signed-off-by: Heiko Schocher <hs@denx.de> > Reported-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> > > --- > @Andrew: could you test this patch, if it solves your issue? > > drivers/mtd/cfi_mtd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c > index ac805ff..894858e 100644 > --- a/drivers/mtd/cfi_mtd.c > +++ b/drivers/mtd/cfi_mtd.c > @@ -226,6 +226,7 @@ int cfi_mtd_init(void) > mtd->flags = MTD_CAP_NORFLASH; > mtd->size = fi->size; > mtd->writesize = 1; > + mtd->writebufsize = mtd->writesize; > Small nitpicking comment: Could you please align the "=" to those lines above? Thanks! Other than that: Acked-by: Stefan Roese <sr@denx.de> Thanks, Stefan
Hello Stefan, Am 31.10.2014 10:44, schrieb Stefan Roese: > Hi Heiko, > > On 31.10.2014 10:39, Heiko Schocher wrote: >> ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" >> introduced the writebufsize field in struct mtd_info, which >> is not initialized in the cfi_flash driver, which leads in >> not working ubi on cfi flashes. Fix it >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> Reported-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> >> >> --- >> @Andrew: could you test this patch, if it solves your issue? >> >> drivers/mtd/cfi_mtd.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c >> index ac805ff..894858e 100644 >> --- a/drivers/mtd/cfi_mtd.c >> +++ b/drivers/mtd/cfi_mtd.c >> @@ -226,6 +226,7 @@ int cfi_mtd_init(void) >> mtd->flags = MTD_CAP_NORFLASH; >> mtd->size = fi->size; >> mtd->writesize = 1; >> + mtd->writebufsize = mtd->writesize; >> > > Small nitpicking comment: Could you please align the "=" to those lines above? Thanks! Hups ... sorry. > Other than that: > > Acked-by: Stefan Roese <sr@denx.de> Thanks! bye, Heiko
diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c index ac805ff..894858e 100644 --- a/drivers/mtd/cfi_mtd.c +++ b/drivers/mtd/cfi_mtd.c @@ -226,6 +226,7 @@ int cfi_mtd_init(void) mtd->flags = MTD_CAP_NORFLASH; mtd->size = fi->size; mtd->writesize = 1; + mtd->writebufsize = mtd->writesize; mtd->_erase = cfi_mtd_erase; mtd->_read = cfi_mtd_read;
ff94bc40af3481d47546595ba73c136de6af6929 "mtd, ubi, ubifs: resync with Linux-3.14" introduced the writebufsize field in struct mtd_info, which is not initialized in the cfi_flash driver, which leads in not working ubi on cfi flashes. Fix it Signed-off-by: Heiko Schocher <hs@denx.de> Reported-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> --- @Andrew: could you test this patch, if it solves your issue? drivers/mtd/cfi_mtd.c | 1 + 1 file changed, 1 insertion(+)