Message ID | 1414740666-13337-10-git-send-email-hs@denx.de |
---|---|
State | Accepted, archived |
Delegated to: | Andreas Bießmann |
Headers | show |
Dear Heiko Schocher, Heiko Schocher <hs@denx.de> writes: >device ready pin is signalling that the device is ready on state 1 >not on 0. Simmiliar as it is in drivers/mtd/nand/nand_spl_simple.c > >Signed-off-by: Heiko Schocher <hs@denx.de> >Reviewed-by: Andreas Bießmann <andreas.devel@googlemail.com> >Reviewed-by: Bo Shen <voice.shen@atmel.com> >Acked-by: Scott Wood <scottwood@freescale.com> >--- > >Changes in v3: >add Acked-by from Scott Wood >add Reviewed-by from Bo Shen > >Changes in v2: >add Reviewed-by: Andreas Bießmann <andreas.devel@googlemail.com> > > drivers/mtd/nand/atmel_nand.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied to u-boot-atmel/master, thanks! Best regards, Andreas Bießmann
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index d6d6f85..3b6093a 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1188,7 +1188,7 @@ static int nand_command(int block, int page, uint32_t offs, u8 cmd) void (*hwctrl)(struct mtd_info *mtd, int cmd, unsigned int ctrl) = this->cmd_ctrl; - while (this->dev_ready(&mtd)) + while (!this->dev_ready(&mtd)) ; if (cmd == NAND_CMD_READOOB) { @@ -1213,7 +1213,7 @@ static int nand_command(int block, int page, uint32_t offs, u8 cmd) hwctrl(&mtd, NAND_CMD_READSTART, NAND_CTRL_CLE | NAND_CTRL_CHANGE); hwctrl(&mtd, NAND_CMD_NONE, NAND_NCE | NAND_CTRL_CHANGE); - while (this->dev_ready(&mtd)) + while (!this->dev_ready(&mtd)) ; return 0; @@ -1353,7 +1353,7 @@ int at91_nand_wait_ready(struct mtd_info *mtd) udelay(this->chip_delay); - return 0; + return 1; } int board_nand_init(struct nand_chip *nand)