| Message ID | 1414731901-2096-1-git-send-email-anton@samba.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Fri, 2014-10-31 at 16:05 +1100, Anton Blanchard wrote: > The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print > a high priority error message when missing. One example where we see > this is QEMU. > > Reduce it to pr_info. I would reduce it even further to pr_dbg. Cheers, Ben. > Signed-off-by: Anton Blanchard <anton@samba.org> > --- > arch/powerpc/platforms/pseries/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c > index 67e4859..57dd7a0 100644 > --- a/arch/powerpc/platforms/pseries/pci.c > +++ b/arch/powerpc/platforms/pseries/pci.c > @@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge) > of_node_put(pdn); > > if (rc) { > - pr_err("no ibm,pcie-link-speed-stats property\n"); > + pr_info("no ibm,pcie-link-speed-stats property\n"); > return 0; > } >
diff --git a/arch/powerpc/platforms/pseries/pci.c b/arch/powerpc/platforms/pseries/pci.c index 67e4859..57dd7a0 100644 --- a/arch/powerpc/platforms/pseries/pci.c +++ b/arch/powerpc/platforms/pseries/pci.c @@ -134,7 +134,7 @@ int pseries_root_bridge_prepare(struct pci_host_bridge *bridge) of_node_put(pdn); if (rc) { - pr_err("no ibm,pcie-link-speed-stats property\n"); + pr_info("no ibm,pcie-link-speed-stats property\n"); return 0; }
The ibm,pcie-link-speed-stats isn't mandatory, so we shouldn't print a high priority error message when missing. One example where we see this is QEMU. Reduce it to pr_info. Signed-off-by: Anton Blanchard <anton@samba.org> --- arch/powerpc/platforms/pseries/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)