Patchwork UBIFS: PTR_ERR return of wrong pointer in check_leaf()

login
register
mail settings
Submitter roel kluin
Date Dec. 7, 2009, 1:21 p.m.
Message ID <4B1D0169.3040507@gmail.com>
Download mbox | patch
Permalink /patch/40492/
State Accepted
Commit b38882f5c066dc681679e90f1903eda323e605b1
Headers show

Comments

roel kluin - Dec. 7, 2009, 1:21 p.m.
Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 fs/ubifs/debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - Dec. 8, 2009, 12:25 p.m.
On Mon, 2009-12-07 at 14:21 +0100, Roel Kluin wrote:
> Return the PTR_ERR of the correct pointer.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>  fs/ubifs/debug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Pushed to ubifs-2.6.git tree, thanks!

Patch

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index dbc093a..8a771c5 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2014,7 +2014,7 @@  static int check_leaf(struct ubifs_info *c, struct ubifs_zbranch *zbr,
 		inum = key_inum_flash(c, &dent->key);
 		fscki1 = read_add_inode(c, priv, inum);
 		if (IS_ERR(fscki1)) {
-			err = PTR_ERR(fscki);
+			err = PTR_ERR(fscki1);
 			ubifs_err("error %d while processing entry node and "
 				  "trying to find parent inode node %lu",
 				  err, (unsigned long)inum);