| Message ID | 20141029192729.GF6582@oracle.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sowmini Varadhan <sowmini.varadhan@oracle.com> Date: Wed, 29 Oct 2014 15:27:29 -0400 > Challenge ACK is described in RFC 5961, fix typo. > > Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> This TCP change has nothing to do with your sunvnet driver changes. Please do not ever mix unrelated changes like this within a series. Submit the TCP change on it's own, and then respin the sunvnet driver specific patches separately. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On (10/30/14 12:32), David Miller wrote: > > Please do not ever mix unrelated changes like this within a series. > > Submit the TCP change on it's own, and then respin the sunvnet > driver specific patches separately. Done. fwiw, I ran into this comment when debugging something in sunvnet, and was quite confused by the rfc 5691 reference :-) --Sowmini -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index a12b455..d285962 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -5028,7 +5028,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb, /* step 3: check security and precedence [ignored] */ /* step 4: Check for a SYN - * RFC 5691 4.2 : Send a challenge ack + * RFC 5961 4.2 : Send a challenge ack */ if (th->syn) { syn_challenge:
Challenge ACK is described in RFC 5961, fix typo. Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)