diff mbox

[v2] Makefile: improve detection of make "-s" flag

Message ID 1414573980-20973-1-git-send-email-fabio.porcedda@gmail.com
State Superseded
Headers show

Commit Message

Fabio Porcedda Oct. 29, 2014, 9:13 a.m. UTC 
Because it's just checked the presence of the "s" character even a
  make --warn-undefined-variables
is detected as a silent build so fix this by filtering out long options.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
---

Notes:
    v2:
     - remove spurious space at the beginning of the QUIET variable (Arnout)

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Porcedda Oct. 29, 2014, 9:17 a.m. UTC | #1 
I've sent a new revision:
http://patchwork.ozlabs.org/patch/404484/

BR
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 907a0fc..19997c7 100644
--- a/Makefile
+++ b/Makefile
@@ -303,7 +303,7 @@  GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
 TARGETS :=
 
 # silent mode requested?
-QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
+QUIET := $(if $(findstring s, $(filter-out --%, $(MAKEFLAGS))),-q)
 
 # Strip off the annoying quoting
 ARCH := $(call qstrip,$(BR2_ARCH))