From patchwork Tue Oct 28 06:37:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 404060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7C63C14007D for ; Tue, 28 Oct 2014 17:40:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542AbaJ1GkY (ORCPT ); Tue, 28 Oct 2014 02:40:24 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:39594 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbaJ1GkV (ORCPT ); Tue, 28 Oct 2014 02:40:21 -0400 Received: by mail-pd0-f174.google.com with SMTP id p10so26858pdj.33 for ; Mon, 27 Oct 2014 23:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=O36lQbLswRpkSZUKYMxzdBTAimVD8TmuUNmEy0cV8ns=; b=aG9hvMX8HrgCPIQwDZ0kzW7HVs908u4KSm5T38ULQv/j/M9Piy+dyOdiEmdglABVSb J0vnO3BlBW7brb0rUrG6UocrxJwzXH02QcFwyLyELuyzEEqbfyoowwRH+zPI4Um0r8Cb 1rh3sNUxYUXFh3rUYHP1UkQfWtRDRrcFY6XDK++KE91zBpPIjqhjL4krsEU/MmpfHkDH sT2qQQqbndffmTMGu9q3Zs5EwhDNXYB8sjP+cT9CY6nokTEsGFvM+k3prnElNigfQ+82 v67IN7MEgXI6IFhBKNjWFBHPfuHOyn50z10OYzDIp6bQ9/C81IBk6qJnEiZVif7sKpO7 3bUQ== X-Received: by 10.69.26.133 with SMTP id iy5mr1384541pbd.114.1414478420702; Mon, 27 Oct 2014 23:40:20 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id ql6sm653315pbb.39.2014.10.27.23.40.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 27 Oct 2014 23:40:19 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: linux-gpio@vger.kernel.org Cc: gnurou@gmail.com, linus.walleij@linaro.org, Varka Bhadram Subject: [PATCH gpio v2 3/3] gpio: gpio-tb10x: remove duplicate check on resource Date: Tue, 28 Oct 2014 12:07:07 +0530 Message-Id: <1414478227-24674-4-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414478227-24674-1-git-send-email-varkab@cdac.in> References: <1414478227-24674-1-git-send-email-varkab@cdac.in> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram Acked-by: Alexandre Courbot --- drivers/gpio/gpio-tb10x.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 9e615be..8b1e8c0 100644 --- a/drivers/gpio/gpio-tb10x.c +++ b/drivers/gpio/gpio-tb10x.c @@ -195,18 +195,13 @@ static int tb10x_gpio_probe(struct platform_device *pdev) if (of_property_read_u32(dn, "abilis,ngpio", &ngpio)) return -EINVAL; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) { - dev_err(&pdev->dev, "No memory resource defined.\n"); - return -EINVAL; - } - tb10x_gpio = devm_kzalloc(&pdev->dev, sizeof(*tb10x_gpio), GFP_KERNEL); if (tb10x_gpio == NULL) return -ENOMEM; spin_lock_init(&tb10x_gpio->spinlock); + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); tb10x_gpio->base = devm_ioremap_resource(&pdev->dev, mem); if (IS_ERR(tb10x_gpio->base)) return PTR_ERR(tb10x_gpio->base);