diff mbox

trinity: Disable for Microblaze architecture

Message ID 1414426270-14436-1-git-send-email-Vincent.Riera@imgtec.com
State Superseded
Headers show

Commit Message

Vicente Olivert Riera Oct. 27, 2014, 4:11 p.m. UTC
This package doesn't support the Microblaze architecture. The full list
of supported architectures is in the trinity website, and Microblaze is
not among them.

Fixes:
	http://autobuild.buildroot.net/results/ea7/ea788f1f0ed5ee4e9b1bf0c8a0d1304e7467dc77/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/trinity/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Oct. 27, 2014, 4:43 p.m. UTC | #1
Dear Vicente Olivert Riera,

On Mon, 27 Oct 2014 16:11:10 +0000, Vicente Olivert Riera wrote:
> This package doesn't support the Microblaze architecture. The full list
> of supported architectures is in the trinity website, and Microblaze is
> not among them.

Then what we want is not something like the patch you propose, but
instead a patch using positive logic to enable Trinity only on the
architecture that are known to work.

The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64,
MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not
only Microblaze is going to cause issue, but also Blackfin, ARC,
Xtensa, SPARC 32 bits, and probably some others I forgot.

Can you respin the patch with something like:

	depends BR2_... || BR2_... || BR2_...

Thanks!

Thomas
Vicente Olivert Riera Oct. 27, 2014, 5:19 p.m. UTC | #2
Dear Thomas Petazzoni,

On 10/27/2014 04:43 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 27 Oct 2014 16:11:10 +0000, Vicente Olivert Riera wrote:
>> This package doesn't support the Microblaze architecture. The full list
>> of supported architectures is in the trinity website, and Microblaze is
>> not among them.
>
> Then what we want is not something like the patch you propose, but
> instead a patch using positive logic to enable Trinity only on the
> architecture that are known to work.
>
> The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64,
> MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not
> only Microblaze is going to cause issue, but also Blackfin, ARC,
> Xtensa, SPARC 32 bits, and probably some others I forgot.
>
> Can you respin the patch with something like:
>
> 	depends BR2_... || BR2_... || BR2_...
>
> Thanks!
>
> Thomas

Done: http://patchwork.ozlabs.org/patch/403703/

I have marked the former patch as superseded.

Best regards,
Thomas Petazzoni Oct. 27, 2014, 6:30 p.m. UTC | #3
Dear Vicente Olivert Riera,

On Mon, 27 Oct 2014 17:19:36 +0000, Vicente Olivert Riera wrote:

> Done: http://patchwork.ozlabs.org/patch/403703/

This is exactly the same patch as before. What happened ? :-)

Thomas
Vicente Olivert Riera Oct. 28, 2014, 9:31 a.m. UTC | #4
Dear Thomas Petazzoni,

On 10/27/2014 06:30 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 27 Oct 2014 17:19:36 +0000, Vicente Olivert Riera wrote:
>
>> Done: http://patchwork.ozlabs.org/patch/403703/
>
> This is exactly the same patch as before. What happened ? :-)

git add... :-(

I have sent the right patch now.

Thanks!
diff mbox

Patch

diff --git a/package/trinity/Config.in b/package/trinity/Config.in
index de9c467..9882573 100644
--- a/package/trinity/Config.in
+++ b/package/trinity/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_TRINITY
 	bool "trinity"
+	depends on !BR2_microblazeel && !BR2_microblazeeb
 	help
 	  A Linux System call fuzz tester