Patchwork [2/2] monitor: Introduce 'block_passwd' command

login
register
mail settings
Submitter Luiz Capitulino
Date Dec. 4, 2009, 5:24 p.m.
Message ID <1259947449-17576-3-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/40358/
State New
Headers show

Comments

Luiz Capitulino - Dec. 4, 2009, 5:24 p.m.
When using encrypted disk images, QEMU will prompt the user
for passwords when started.

This makes sense for the user protocol, but doesn't for QMP.

The solution is to have Monitor command which allows the user
or a Client to set passwords in advance, so that we avoid
the prompt completely.

This is what block_passwd does, for example:

(QEMU) block_passwd ide0-hd0 foobar

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c       |   16 ++++++++++++++++
 qemu-monitor.hx |   14 ++++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)

Patch

diff --git a/monitor.c b/monitor.c
index 47b11f8..a3ae488 100644
--- a/monitor.c
+++ b/monitor.c
@@ -807,6 +807,22 @@  static void do_eject(Monitor *mon, const QDict *qdict, QObject **ret_data)
     eject_device(mon, bs, force);
 }
 
+static void do_block_set_passwd(Monitor *mon, const QDict *qdict,
+                                QObject **ret_data)
+{
+    BlockDriverState *bs;
+
+    bs = bdrv_find(qdict_get_str(qdict, "device"));
+    if (!bs) {
+        qemu_error_new(QERR_DEVICE_NOT_FOUND, qdict_get_str(qdict, "device"));
+        return;
+    }
+
+    if (bdrv_set_key(bs, qdict_get_str(qdict, "password")) < 0) {
+        qemu_error_new(QERR_INVALID_PASSWORD);
+    }
+}
+
 static void do_change_block(Monitor *mon, const char *device,
                             const char *filename, const char *fmt)
 {
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 93cbb62..d7c6522 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -1048,6 +1048,20 @@  Close the file descriptor previously assigned to @var{fdname} using the
 used by another monitor command.
 ETEXI
 
+    {
+        .name       = "block_passwd",
+        .args_type  = "device:B,password:s",
+        .params     = "block_passwd device password",
+        .help       = "set the password of encrypted block devices",
+        .user_print = monitor_user_noop,
+        .mhandler.cmd_new = do_block_set_passwd,
+    },
+
+STEXI
+@item block_passwd @var{device} @var{password}
+Set the encrypted device @var{device} password to @var{password}
+ETEXI
+
 STEXI
 @end table
 ETEXI