From patchwork Fri Oct 24 14:29:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 402891 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2F36814007D for ; Sat, 25 Oct 2014 01:30:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756074AbaJXOaR (ORCPT ); Fri, 24 Oct 2014 10:30:17 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38278 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755386AbaJXOaP (ORCPT ); Fri, 24 Oct 2014 10:30:15 -0400 Received: by mail-wi0-f169.google.com with SMTP id q5so1328790wiv.0 for ; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MuG2bGTVlP7HwtFMkuq0ezjTREJ0g4jaJz0UAF0tWXE=; b=hkmSM7+Q0lrV/8sawAxIhmTe4HAXQ15u6UZVa2Oe8etUts4u+S+DDMyUJgzOSwtR6s 5q9N7kQOJ6ZGPZGNonHqHQRElC4WU0F/52n42CnqgZbwc/C4UTjKu8EtHXcBPCnvmQfF IZnJNU+R/SHpG/ttshvsBxLLhJl9TIGIb8IiTEBcmmXEXrEsfBg1HMW4ltnLNOhlYYWD q1egheeBdYA0P5wHgs8nfbCWyXei3PXPAgfBlq5leHo+Ez5w4oEwvdo6qed35+iHO5fn WIsROb+ci6g4W+snjnDh93sdOVD6K2YqpceGRyMo9RhZHymc8X9eDZNz7fJAkb1WAbWR 1Dag== X-Gm-Message-State: ALoCoQnPc2WZ0dTAks/7xdUbwrWdDMeWtRu5eohCt88Xb8Ja8eOASPx0EvGsBuDJAV0RQqXXp5a8 X-Received: by 10.194.221.105 with SMTP id qd9mr5142022wjc.51.1414161014033; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id u2sm5836837wjz.11.2014.10.24.07.30.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 07:30:13 -0700 (PDT) From: Daniel Thompson To: Jiri Kosina Cc: Daniel Thompson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , Linus Walleij , Alexandre Courbot Subject: [PATCH] gpio: msm-v1: Fix typo in function argument Date: Fri, 24 Oct 2014 15:29:57 +0100 Message-Id: <1414160997-30575-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org irq_set_irq_wake() treats its second argument as a boolean. It is much easier to read code when constant booleans are either 0 or 1! This particular line of code distracted me somewhat when I was doing a bit of work in a code browser since it (spuriously) got me worried that I had misunderstood how irq_set_irq_wake() worked. Signed-off-by: Daniel Thompson Cc: Linus Walleij Cc: Alexandre Courbot Reviewed-by: Alexandre Courbot --- drivers/gpio/gpio-msm-v1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c index 73b7396..997e61e 100644 --- a/drivers/gpio/gpio-msm-v1.c +++ b/drivers/gpio/gpio-msm-v1.c @@ -686,7 +686,7 @@ static int gpio_msm_v1_probe(struct platform_device *pdev) irq_set_chained_handler(irq1, msm_gpio_irq_handler); irq_set_chained_handler(irq2, msm_gpio_irq_handler); irq_set_irq_wake(irq1, 1); - irq_set_irq_wake(irq2, 2); + irq_set_irq_wake(irq2, 1); return 0; }