[11/13] AArch64: Cleanup fenv implementation
diff mbox

Message ID 001501cfeee7$d6128df0$8237a9d0$@com
State New
Headers show

Commit Message

Wilco Oct. 23, 2014, 5:36 p.m. UTC
Call libc_fetestexcept_aarch64 from math_private.h rather than duplicating functionality.

ChangeLog:
2014-10-23  Wilco Dijkstra  <wdijkstr@arm.com>

	* sysdeps/aarch64/fpu/ftestexcept.c (fetestexcept):
	Call libc_fetestexcept_aarch64.

---
 sysdeps/aarch64/fpu/ftestexcept.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Comments

Marcus Shawcroft Dec. 18, 2014, 4:11 p.m. UTC | #1
On 23 October 2014 at 18:36, Wilco Dijkstra <wdijkstr@arm.com> wrote:

> -#include <fenv.h>

Likewise, don't drop this header.  Otherwise OK.
/Marcus

> -#include <fpu_control.h>
> +#include <math_private.h>
>
>  int
>  fetestexcept (int excepts)
>  {
> -  fpu_fpsr_t fpsr;
> -
> -  /* Get current exceptions.  */
> -  _FPU_GETFPSR (fpsr);
> -
> -  return fpsr & excepts & FE_ALL_EXCEPT;
> +  return libc_fetestexcept_aarch64 (excepts);
>  }
>  libm_hidden_def (fetestexcept)
> --
> 1.9.1
>
>

Patch
diff mbox

diff --git a/sysdeps/aarch64/fpu/ftestexcept.c b/sysdeps/aarch64/fpu/ftestexcept.c
index 73e01d4..74e2d0f 100644
--- a/sysdeps/aarch64/fpu/ftestexcept.c
+++ b/sysdeps/aarch64/fpu/ftestexcept.c
@@ -16,17 +16,11 @@ 
    License along with the GNU C Library; if not, see
    <http://www.gnu.org/licenses/>.  */
 
-#include <fenv.h>
-#include <fpu_control.h>
+#include <math_private.h>
 
 int
 fetestexcept (int excepts)
 {
-  fpu_fpsr_t fpsr;
-
-  /* Get current exceptions.  */
-  _FPU_GETFPSR (fpsr);
-
-  return fpsr & excepts & FE_ALL_EXCEPT;
+  return libc_fetestexcept_aarch64 (excepts);
 }
 libm_hidden_def (fetestexcept)