| Message ID | 1413951386-29645-3-git-send-email-varkab@cdac.in |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/22/2014 8:16 AM, Varka Bhadram wrote: > devm_ioremap_resource checks platform_get_resource() return value. > We can remove the duplicate check here. > Signed-off-by: Varka Bhadram <varkab@cdac.in> > --- > drivers/net/ethernet/wiznet/w5300.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c > index f961f14..315d090 100644 > --- a/drivers/net/ethernet/wiznet/w5300.c > +++ b/drivers/net/ethernet/wiznet/w5300.c > @@ -558,8 +558,7 @@ static int w5300_hw_probe(struct platform_device *pdev) > } > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem) > - return -ENXIO; > + > mem_size = resource_size(mem); Same problem as in the patch #1 > > priv->base = devm_ioremap_resource(&pdev->dev, mem); > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/22/2014 05:14 PM, Sergei Shtylyov wrote: > On 10/22/2014 8:16 AM, Varka Bhadram wrote: > >> devm_ioremap_resource checks platform_get_resource() return value. >> We can remove the duplicate check here. > >> Signed-off-by: Varka Bhadram <varkab@cdac.in> >> --- >> drivers/net/ethernet/wiznet/w5300.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> diff --git a/drivers/net/ethernet/wiznet/w5300.c >> b/drivers/net/ethernet/wiznet/w5300.c >> index f961f14..315d090 100644 >> --- a/drivers/net/ethernet/wiznet/w5300.c >> +++ b/drivers/net/ethernet/wiznet/w5300.c >> @@ -558,8 +558,7 @@ static int w5300_hw_probe(struct platform_device >> *pdev) >> } >> >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!mem) >> - return -ENXIO; >> + >> mem_size = resource_size(mem); > > Same problem as in the patch #1 > I will fix it . Thanks >> >> priv->base = devm_ioremap_resource(&pdev->dev, mem); >> > > WBR, Sergei >
diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index f961f14..315d090 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c @@ -558,8 +558,7 @@ static int w5300_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; + mem_size = resource_size(mem); priv->base = devm_ioremap_resource(&pdev->dev, mem);
devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram <varkab@cdac.in> --- drivers/net/ethernet/wiznet/w5300.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)