| Message ID | 1413821173-18347-2-git-send-email-vinod.koul@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Oct 20, 2014 at 09:36:13PM +0530, Vinod Koul wrote: > The driver was also using own method to do 32bit copy, turns out > we have a kernel API so use that instead > > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > --- > drivers/mtd/nand/mxc_nand.c | 10 +++------- > 1 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > index dba262b..3794cd7 100644 > --- a/drivers/mtd/nand/mxc_nand.c > +++ b/drivers/mtd/nand/mxc_nand.c > @@ -280,14 +280,10 @@ static void memcpy32_fromio(void *trg, const void __iomem *src, size_t size) > *t++ = __raw_readl(s++); > } > > -static void memcpy32_toio(void __iomem *trg, const void *src, int size) > +static inline void memcpy32_toio(void __iomem *trg, const void *src, int size) > { > - int i; > - u32 __iomem *t = trg; > - const u32 *s = src; > - > - for (i = 0; i < (size >> 2); i++) > - __raw_writel(*s++, t++); > + /* __iowrite32_copy use 32bit size values so divide by 4 */ > + __iowrite32_copy(trg, src, size/4); Fixed up the spacing around the division, and pushed to l2-mtd.git. > } > > static int check_int_v3(struct mxc_nand_host *host) Brian
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index dba262b..3794cd7 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -280,14 +280,10 @@ static void memcpy32_fromio(void *trg, const void __iomem *src, size_t size) *t++ = __raw_readl(s++); } -static void memcpy32_toio(void __iomem *trg, const void *src, int size) +static inline void memcpy32_toio(void __iomem *trg, const void *src, int size) { - int i; - u32 __iomem *t = trg; - const u32 *s = src; - - for (i = 0; i < (size >> 2); i++) - __raw_writel(*s++, t++); + /* __iowrite32_copy use 32bit size values so divide by 4 */ + __iowrite32_copy(trg, src, size/4); } static int check_int_v3(struct mxc_nand_host *host)
The driver was also using own method to do 32bit copy, turns out we have a kernel API so use that instead Signed-off-by: Vinod Koul <vinod.koul@intel.com> --- drivers/mtd/nand/mxc_nand.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-)