| Message ID | 1413813009-20149-1-git-send-email-jkrause@posteo.de |
|---|---|
| State | Superseded |
| Headers | show |
Jörg, All, On 2014-10-20 15:50 +0200, Jörg Krause spake thusly: > Signed-off-by: Jörg Krause <jkrause@posteo.de> [--SNIP--] > diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in > new file mode 100644 > index 0000000..5a79452 > --- /dev/null > +++ b/package/libupnpp/Config.in > @@ -0,0 +1,20 @@ > +config BR2_PACKAGE_LIBUPNPP > + bool "libupnpp" > + select BR2_PACKAGE_EXPAT > + select BR2_PACKAGE_LIBCURL > + select BR2_PACKAGE_LIBUPNP > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_LARGEFILE # libupnp > + depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto Nice! It proves you did quite some testing! :-) > + help > + The libupnpp C++ library wraps libupnp for easier use by upmpdcli and > + upplay. > + > + http://www.lesbonscomptes.com/upmpdcli/ > + > +comment "upmpdcli needs a toolchain w/ C++, largefile, threads" 'upmpdcli', really? Otherwise, looks good. With the above mishap fixed, you can add my: Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \ > + !BR2_TOOLCHAIN_HAS_THREADS > diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk > new file mode 100644 > index 0000000..d46de14 > --- /dev/null > +++ b/package/libupnpp/libupnpp.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# libupnpp > +# > +################################################################################ > + > +LIBUPNPP_VERSION = 0.8.5 > +LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads > +LIBUPNPP_LICENSE = GPLv2+ > +LIBUPNPP_LICENSE_FILES = COPYING > +LIBUPNPP_INSTALL_STAGING = YES > +LIBUPNPP_DEPENDENCIES = expat libcurl libupnp > + > +$(eval $(autotools-package)) > -- > 2.1.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Jörg, All, On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly: > On 2014-10-20 15:50 +0200, Jörg Krause spake thusly: > > Signed-off-by: Jörg Krause <jkrause@posteo.de> > [--SNIP--] > > diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in > > new file mode 100644 > > index 0000000..5a79452 > > --- /dev/null > > +++ b/package/libupnpp/Config.in > > @@ -0,0 +1,20 @@ > > +config BR2_PACKAGE_LIBUPNPP > > + bool "libupnpp" > > + select BR2_PACKAGE_EXPAT > > + select BR2_PACKAGE_LIBCURL > > + select BR2_PACKAGE_LIBUPNP > > + depends on BR2_INSTALL_LIBSTDCPP > > + depends on BR2_LARGEFILE # libupnp > > + depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp > > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc > > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto > > + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto > > Nice! It proves you did quite some testing! :-) I withdraw that comment: the dependencies were copied as-is from upmpdcli. Are they still required for libupnpp? > > + help > > + The libupnpp C++ library wraps libupnp for easier use by upmpdcli and > > + upplay. > > + > > + http://www.lesbonscomptes.com/upmpdcli/ > > + > > +comment "upmpdcli needs a toolchain w/ C++, largefile, threads" > > 'upmpdcli', really? > > Otherwise, looks good. With the above mishap fixed, you can add my: > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Sorry, I withdraw my rev tag, because of the above. That's what you get by not reviewing the whole series before replying to a patch... Sorry... :-( J"org, that does not mean this is faulty, I just wnat to have an answer to the above before I can give my rev tag. Regards, Yann E. MORIN.
Yann, All, On 10/20/2014 07:50 PM, Yann E. MORIN wrote: > Jörg, All, > > On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly: >> On 2014-10-20 15:50 +0200, Jörg Krause spake thusly: >>> Signed-off-by: Jörg Krause <jkrause@posteo.de> >> [--SNIP--] >>> diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in >>> new file mode 100644 >>> index 0000000..5a79452 >>> --- /dev/null >>> +++ b/package/libupnpp/Config.in >>> @@ -0,0 +1,20 @@ >>> +config BR2_PACKAGE_LIBUPNPP >>> + bool "libupnpp" >>> + select BR2_PACKAGE_EXPAT >>> + select BR2_PACKAGE_LIBCURL >>> + select BR2_PACKAGE_LIBUPNP >>> + depends on BR2_INSTALL_LIBSTDCPP >>> + depends on BR2_LARGEFILE # libupnp >>> + depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp >>> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc >>> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto >>> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto >> Nice! It proves you did quite some testing! :-) > I withdraw that comment: the dependencies were copied as-is from > upmpdcli. Are they still required for libupnpp? I've checked this. They are still required. gcc 4.3.5 does not support C++11 keyword `auto`. > >>> + help >>> + The libupnpp C++ library wraps libupnp for easier use by upmpdcli and >>> + upplay. >>> + >>> + http://www.lesbonscomptes.com/upmpdcli/ >>> + >>> +comment "upmpdcli needs a toolchain w/ C++, largefile, threads" >> 'upmpdcli', really? Copy & paste error. Fixed! >> >> Otherwise, looks good. With the above mishap fixed, you can add my: >> >> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Sorry, I withdraw my rev tag, because of the above. That's what you get > by not reviewing the whole series before replying to a patch... > Sorry... :-( > > J"org, that does not mean this is faulty, I just wnat to have an answer > to the above before I can give my rev tag. > I will submit a fixed patch.
diff --git a/package/Config.in b/package/Config.in index 89b46dc..4626f00 100644 --- a/package/Config.in +++ b/package/Config.in @@ -816,6 +816,7 @@ menu "Networking" source "package/libtirpc/Config.in" source "package/libtorrent/Config.in" source "package/libupnp/Config.in" + source "package/libupnpp/Config.in" source "package/libvncserver/Config.in" source "package/libwebsockets/Config.in" source "package/neon/Config.in" diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in new file mode 100644 index 0000000..5a79452 --- /dev/null +++ b/package/libupnpp/Config.in @@ -0,0 +1,20 @@ +config BR2_PACKAGE_LIBUPNPP + bool "libupnpp" + select BR2_PACKAGE_EXPAT + select BR2_PACKAGE_LIBCURL + select BR2_PACKAGE_LIBUPNP + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_LARGEFILE # libupnp + depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto + help + The libupnpp C++ library wraps libupnp for easier use by upmpdcli and + upplay. + + http://www.lesbonscomptes.com/upmpdcli/ + +comment "upmpdcli needs a toolchain w/ C++, largefile, threads" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \ + !BR2_TOOLCHAIN_HAS_THREADS diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk new file mode 100644 index 0000000..d46de14 --- /dev/null +++ b/package/libupnpp/libupnpp.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# libupnpp +# +################################################################################ + +LIBUPNPP_VERSION = 0.8.5 +LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads +LIBUPNPP_LICENSE = GPLv2+ +LIBUPNPP_LICENSE_FILES = COPYING +LIBUPNPP_INSTALL_STAGING = YES +LIBUPNPP_DEPENDENCIES = expat libcurl libupnp + +$(eval $(autotools-package))
Signed-off-by: Jörg Krause <jkrause@posteo.de> --- package/Config.in | 1 + package/libupnpp/Config.in | 20 ++++++++++++++++++++ package/libupnpp/libupnpp.mk | 14 ++++++++++++++ 3 files changed, 35 insertions(+) create mode 100644 package/libupnpp/Config.in create mode 100644 package/libupnpp/libupnpp.mk