diff mbox

[RFC/PATCH,v3,07/11] package/kodi: Enable install to STAGING_DIR, needed for audioencoder addons

Message ID 1413661503-5382-8-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Oct. 18, 2014, 7:44 p.m. UTC 
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/kodi.mk |    2 ++
 1 file changed, 2 insertions(+)

Comments

Yann E. MORIN Oct. 18, 2014, 10:37 p.m. UTC | #1 
Bernd, All,

On 2014-10-18 21:44 +0200, Bernd Kuhls spake thusly:
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi/kodi.mk |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index fc24c4d..57baeed 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -9,6 +9,8 @@ KODI_SOURCE = $(KODI_VERSION).tar.gz
>  KODI_SITE = https://github.com/xbmc/xbmc/archive
>  KODI_LICENSE = GPLv2
>  KODI_LICENSE_FILES = LICENSE.GPL
> +# needed for audioencoder addons
> +KODI_INSTALL_STAGING = YES

I'm not sure I understand why you need Kodi in staging.

In this patch, you state that audioencoder addons need it at build time,
but in each such audioencoder addons, you state the dependency is only a
runtime dependency.

Care to expand a bit on this, please?

Regards,
Yann E. MORIN.

>  # Kodi needs host-sdl_image (and therefore host-sdl) for a host tools it builds
>  # called TexturePacker. It is responsible to take all the images used in the
>  # GUI and pack them in a blob.
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Bernd Kuhls Oct. 19, 2014, 7:06 a.m. UTC | #2 
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in 
news:20141018223754.GA14899@free.fr:

>> +# needed for audioencoder addons
>> +KODI_INSTALL_STAGING = YES
> 
> I'm not sure I understand why you need Kodi in staging.

Hi,

the build system (cmake) of all audioencoder addons checks for an installed 
xbmc/kodi, for example:

https://github.com/xbmc/audioencoder.flac/blob/master/CMakeLists.txt#L9

I will update the comments.

Regards, Bernd
diff mbox

Patch

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index fc24c4d..57baeed 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -9,6 +9,8 @@  KODI_SOURCE = $(KODI_VERSION).tar.gz
 KODI_SITE = https://github.com/xbmc/xbmc/archive
 KODI_LICENSE = GPLv2
 KODI_LICENSE_FILES = LICENSE.GPL
+# needed for audioencoder addons
+KODI_INSTALL_STAGING = YES
 # Kodi needs host-sdl_image (and therefore host-sdl) for a host tools it builds
 # called TexturePacker. It is responsible to take all the images used in the
 # GUI and pack them in a blob.