Patchwork [41/41] virtio: virtio_save/load are not used anymore

login
register
mail settings
Submitter Juan Quintela
Date Dec. 2, 2009, 12:04 p.m.
Message ID <0762d0b2053d2133f41974261cb8a264ba3d2298.1259754427.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/40054/
State New
Headers show

Comments

Juan Quintela - Dec. 2, 2009, 12:04 p.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/virtio.c |   10 ----------
 hw/virtio.h |    4 ----
 2 files changed, 0 insertions(+), 14 deletions(-)
Michael S. Tsirkin - Dec. 2, 2009, 6:17 p.m.
You probably can just roll "not used anymore"
lines in the parent patch. It does not help
splitting this part out IMO.

On Wed, Dec 02, 2009 at 01:04:39PM +0100, Juan Quintela wrote:
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  hw/virtio.c |   10 ----------
>  hw/virtio.h |    4 ----
>  2 files changed, 0 insertions(+), 14 deletions(-)
> 
> diff --git a/hw/virtio.c b/hw/virtio.c
> index 73dae7c..2c4ac0b 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -730,16 +730,6 @@ const VMStateDescription vmstate_virtio = {
>      }
>  };
> 
> -void virtio_save(VirtIODevice *vdev, QEMUFile *f)
> -{
> -    vmstate_save_state(f, &vmstate_virtio, vdev);
> -}
> -
> -int virtio_load(VirtIODevice *vdev, QEMUFile *f)
> -{
> -    return vmstate_load_state(f, &vmstate_virtio, vdev, vmstate_virtio.version_id);
> -}
> -
>  void virtio_cleanup(VirtIODevice *vdev)
>  {
>      if (vdev->config)
> diff --git a/hw/virtio.h b/hw/virtio.h
> index ac7b8eb..fe3ba7a 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -135,10 +135,6 @@ extern const VMStateDescription vmstate_virtio;
>  #define VMSTATE_VIRTIO(_field, _state)                                         \
>      VMSTATE_STRUCT_TEST(_field, _state, NULL, 0, vmstate_virtio, VirtIODevice)
> 
> -void virtio_save(VirtIODevice *vdev, QEMUFile *f);
> -
> -int virtio_load(VirtIODevice *vdev, QEMUFile *f);
> -
>  void virtio_cleanup(VirtIODevice *vdev);
> 
>  void virtio_notify_config(VirtIODevice *vdev);
> -- 
> 1.6.5.2
Juan Quintela - Dec. 2, 2009, 6:57 p.m.
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> You probably can just roll "not used anymore"
> lines in the parent patch. It does not help
> splitting this part out IMO.

I reordered the other patches several times.

Later, Juan.

Patch

diff --git a/hw/virtio.c b/hw/virtio.c
index 73dae7c..2c4ac0b 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -730,16 +730,6 @@  const VMStateDescription vmstate_virtio = {
     }
 };

-void virtio_save(VirtIODevice *vdev, QEMUFile *f)
-{
-    vmstate_save_state(f, &vmstate_virtio, vdev);
-}
-
-int virtio_load(VirtIODevice *vdev, QEMUFile *f)
-{
-    return vmstate_load_state(f, &vmstate_virtio, vdev, vmstate_virtio.version_id);
-}
-
 void virtio_cleanup(VirtIODevice *vdev)
 {
     if (vdev->config)
diff --git a/hw/virtio.h b/hw/virtio.h
index ac7b8eb..fe3ba7a 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -135,10 +135,6 @@  extern const VMStateDescription vmstate_virtio;
 #define VMSTATE_VIRTIO(_field, _state)                                         \
     VMSTATE_STRUCT_TEST(_field, _state, NULL, 0, vmstate_virtio, VirtIODevice)

-void virtio_save(VirtIODevice *vdev, QEMUFile *f);
-
-int virtio_load(VirtIODevice *vdev, QEMUFile *f);
-
 void virtio_cleanup(VirtIODevice *vdev);

 void virtio_notify_config(VirtIODevice *vdev);