Patchwork [RFC,MTD-UTILS] : flash_lock: fix length being passed

login
register
mail settings
Submitter vimal singh
Date Dec. 2, 2009, 2:33 p.m.
Message ID <ce9ab5790912020633o24dbab61le9ab2d14e0b5177e@mail.gmail.com>
Download mbox | patch
Permalink /patch/40052/
State RFC
Headers show

Comments

vimal singh - Dec. 2, 2009, 2:33 p.m.
On Wed, Dec 2, 2009 at 7:58 PM, Vimal Singh <vimal.newwork@gmail.com> wrote:
> This patch fixes the 'length' calculation.
> Making it:
> +       mtdLockInfo.length = (num_sectors - 1) * mtdInfo.erasesize;
> Rather:
> -       mtdLockInfo.length = num_sectors * mtdInfo.erasesize;
>
> Say there are 240 blocks present in the device. Then:
> offset starts from: 0x0
> and full size of device: 0x1E00000
>
> doing: 240 * 0x20000 gives -> 0x1E00000
> But last block address should be 0x1DE0000 (which spans for 0x20000
> bytes, adding upto size of 0x1E00000)
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
>
> --- flash_lock.c.org    2009-11-24 19:33:18.000000000 +0530
> +++ flash_lock.c        2009-11-24 19:33:13.000000000 +0530

Sorry, this patch was generated using 'diff'. Below is the correct patch.
-vimal

This patch fixes the 'length' calculation.
Making it:
       mtdLockInfo.length = (num_sectors - 1) * mtdInfo.erasesize;
Rather:
       mtdLockInfo.length = num_sectors * mtdInfo.erasesize;

Say there are 240 blocks present in the device. Then:
offset starts from: 0x0
and full size of device: 0x1E00000

doing: 240 * 0x20000 gives -> 0x1E00000
But last block address should be 0x1DE0000 (which spans for 0x20000
bytes, adding upto size of 0x1E00000)

Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---

Patch

--- a/flash_lock.c	2009-11-24 19:33:18.000000000 +0530
+++ b/flash_lock.c	2009-11-24 19:33:13.000000000 +0530
@@ -71,7 +71,7 @@  int main(int argc, char *argv[])
 	}

 	mtdLockInfo.start = ofs;
-	mtdLockInfo.length = num_sectors * mtdInfo.erasesize;
+	mtdLockInfo.length = (num_sectors - 1) * mtdInfo.erasesize;
 	if(ioctl(fd, MEMLOCK, &mtdLockInfo))
 	{
 		fprintf(stderr, "Could not lock MTD device: %s\n", argv[1]);
@@ -81,4 +81,3 @@  int main(int argc, char *argv[])

 	return 0;
 }
-