| Message ID | 1413498543-643-1-git-send-email-jkrause@posteo.de |
|---|---|
| State | Accepted |
| Headers | show |
Hi all, On 10/17/2014 12:28 AM, Jörg Krause wrote: > * Bump to version 0.19 > * Add boost as dependency > * Add support for libicu > > Signed-off-by: Jörg Krause <jkrause@posteo.de> > --- > Changes v2 -> v3: > - none > Changes v1 -> v2: > - fix missing dependency of boost > --- > package/mpd/Config.in | 4 +++- > package/mpd/mpd.mk | 14 +++++++++++--- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > index 8884464..f2dbbb0 100644 > --- a/package/mpd/Config.in > +++ b/package/mpd/Config.in > @@ -1,12 +1,14 @@ > menuconfig BR2_PACKAGE_MPD > bool "mpd" > depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_LARGEFILE # boost > depends on BR2_USE_WCHAR # libglib2, flac > depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > depends on BR2_USE_MMU # libglib2 > # avr32, sparc & CS powerpc gcc are too old > depends on !(BR2_avr32 || BR2_sparc) > depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009) > + select BR2_PACKAGE_BOOST > select BR2_PACKAGE_LIBGLIB2 > select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) > @@ -211,4 +213,4 @@ comment "mpd needs a toolchain w/ C++, threads, wchar" > depends on BR2_USE_MMU > depends on !(BR2_avr32 || BR2_sparc) > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > - !BR2_TOOLCHAIN_HAS_THREADS > + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE > diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk > index 932df08..1542338 100644 > --- a/package/mpd/mpd.mk > +++ b/package/mpd/mpd.mk > @@ -4,11 +4,11 @@ > # > ################################################################################ > > -MPD_VERSION_MAJOR = 0.18 > -MPD_VERSION = $(MPD_VERSION_MAJOR).16 > +MPD_VERSION_MAJOR = 0.19 > +MPD_VERSION = $(MPD_VERSION_MAJOR) > MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz > MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) > -MPD_DEPENDENCIES = host-pkgconf libglib2 > +MPD_DEPENDENCIES = host-pkgconf boost libglib2 > MPD_LICENSE = GPLv2+ > MPD_LICENSE_FILES = COPYING > > @@ -19,6 +19,14 @@ else > MPD_CONF_OPTS += --with-zeroconf=no > endif > > +# MPD prefers libicu for utf8 collation instead of libglib2. > +ifeq ($(BR2_PACKAGE_ICU),y) > +MPD_DEPENDENCIES += icu > +MPD_CONF_OPTS += --enable-icu > +else > +MPD_CONF_OPTS += --disable-icu > +endif > + > ifeq ($(BR2_PACKAGE_MPD_ALSA),y) > MPD_DEPENDENCIES += alsa-lib > MPD_CONF_OPTS += --enable-alsa sorry for being impatient. Is there anything to take into consideration for this series of patches? Jörg
Jörg, All, On 2014-10-24 21:51 +0200, Jörg Krause spake thusly: > Hi all, > > On 10/17/2014 12:28 AM, Jo:rg Krause wrote: > > * Bump to version 0.19 > * Add boost as dependency* Add support for libicu > Signed-off-by: Jo:rg Krause > [1]<jkrause@posteo.de>---Changes v2 -> v3: > - noneChanges v1 -> v2: - fix missing dependency of boost > --- package/mpd/Config.in | 4 +++- package/mpd/mpd.mk | 14 +++++++++++--- > 2 files changed, 14 insertions(+), 4 deletions(-) > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > index 8884464..f2dbbb0 100644--- a/package/mpd/Config.in > +++ b/package/mpd/Config.in@@ -1,12 +1,14 @@ > menuconfig BR2_PACKAGE_MPD bool "mpd" depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_LARGEFILE # boost depends on BR2_USE_WCHAR # libglib2, flac > depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > depends on BR2_USE_MMU # libglib2 # avr32, sparc & CS powerpc gcc are too old > depends on !(BR2_avr32 || BR2_sparc) depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009) > + select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBGLIB2 > select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) > @@ -211,4 +213,4 @@ comment "mpd needs a toolchain w/ C++, threads, wchar" > depends on BR2_USE_MMU depends on !(BR2_avr32 || BR2_sparc) > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > - !BR2_TOOLCHAIN_HAS_THREADS+ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE > diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk > index 932df08..1542338 100644--- a/package/mpd/mpd.mk > +++ b/package/mpd/mpd.mk@@ -4,11 +4,11 @@ > # ################################################################################ > -MPD_VERSION_MAJOR = 0.18-MPD_VERSION = $(MPD_VERSION_MAJOR).16 > +MPD_VERSION_MAJOR = 0.19+MPD_VERSION = $(MPD_VERSION_MAJOR) > MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz MPD_SITE = > [2]http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) > -MPD_DEPENDENCIES = host-pkgconf libglib2 > +MPD_DEPENDENCIES = host-pkgconf boost libglib2 > MPD_LICENSE = GPLv2+ MPD_LICENSE_FILES = COPYING > @@ -19,6 +19,14 @@ else MPD_CONF_OPTS += --with-zeroconf=no > endif +# MPD prefers libicu for utf8 collation instead of libglib2. > +ifeq ($(BR2_PACKAGE_ICU),y)+MPD_DEPENDENCIES += icu > +MPD_CONF_OPTS += --enable-icu+else+MPD_CONF_OPTS += --disable-icu > +endif+ ifeq ($(BR2_PACKAGE_MPD_ALSA),y) MPD_DEPENDENCIES += alsa-lib > MPD_CONF_OPTS += --enable-alsa > > sorry for being impatient. Is there anything to take into consideration for this series of patches? Someone has to review those patches. We have limited time available to review the many patches that are being sent, so it can take a bit of time for patches to be applied. Just look at the pending list of patches: http://patchwork.ozlabs.org/project/buildroot/list/ You can help reduce this list by reviewing (and testing) pending patches, see: http://buildroot.net/downloads/manual/manual.html#_reviewing_and_testing_patches Regards, Yann E. MORIN.
Dear Jörg Krause, On Fri, 17 Oct 2014 00:28:56 +0200, Jörg Krause wrote: > * Bump to version 0.19 > * Add boost as dependency > * Add support for libicu > > Signed-off-by: Jörg Krause <jkrause@posteo.de> > --- > Changes v2 -> v3: > - none > Changes v1 -> v2: > - fix missing dependency of boost > --- > package/mpd/Config.in | 4 +++- > package/mpd/mpd.mk | 14 +++++++++++--- > 2 files changed, 14 insertions(+), 4 deletions(-) Entire series applied, thanks. There was just one patch where you forgot to add a comment related to a new toolchain dependency (the nfs patch), but other than that, I haven't seen any other issue. I did one build test of a certain configuration, and for the other configurations we'll see what the autobuilders have to say :-) Thanks! Thomas
diff --git a/package/mpd/Config.in b/package/mpd/Config.in index 8884464..f2dbbb0 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -1,12 +1,14 @@ menuconfig BR2_PACKAGE_MPD bool "mpd" depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_LARGEFILE # boost depends on BR2_USE_WCHAR # libglib2, flac depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_MMU # libglib2 # avr32, sparc & CS powerpc gcc are too old depends on !(BR2_avr32 || BR2_sparc) depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009) + select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) @@ -211,4 +213,4 @@ comment "mpd needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_avr32 || BR2_sparc) depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk index 932df08..1542338 100644 --- a/package/mpd/mpd.mk +++ b/package/mpd/mpd.mk @@ -4,11 +4,11 @@ # ################################################################################ -MPD_VERSION_MAJOR = 0.18 -MPD_VERSION = $(MPD_VERSION_MAJOR).16 +MPD_VERSION_MAJOR = 0.19 +MPD_VERSION = $(MPD_VERSION_MAJOR) MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) -MPD_DEPENDENCIES = host-pkgconf libglib2 +MPD_DEPENDENCIES = host-pkgconf boost libglib2 MPD_LICENSE = GPLv2+ MPD_LICENSE_FILES = COPYING @@ -19,6 +19,14 @@ else MPD_CONF_OPTS += --with-zeroconf=no endif +# MPD prefers libicu for utf8 collation instead of libglib2. +ifeq ($(BR2_PACKAGE_ICU),y) +MPD_DEPENDENCIES += icu +MPD_CONF_OPTS += --enable-icu +else +MPD_CONF_OPTS += --disable-icu +endif + ifeq ($(BR2_PACKAGE_MPD_ALSA),y) MPD_DEPENDENCIES += alsa-lib MPD_CONF_OPTS += --enable-alsa
* Bump to version 0.19 * Add boost as dependency * Add support for libicu Signed-off-by: Jörg Krause <jkrause@posteo.de> --- Changes v2 -> v3: - none Changes v1 -> v2: - fix missing dependency of boost --- package/mpd/Config.in | 4 +++- package/mpd/mpd.mk | 14 +++++++++++--- 2 files changed, 14 insertions(+), 4 deletions(-)