diff mbox

[1/1] mp4v2: new package

Message ID 1413445387-12764-1-git-send-email-jkrause@posteo.de
State Superseded
Headers show

Commit Message

Jörg Krause Oct. 16, 2014, 7:43 a.m. UTC 
Signed-off-by: Jörg Krause <jkrause@posteo.de>
---
 package/Config.in        |  1 +
 package/mp4v2/Config.in  | 20 ++++++++++++++++++++
 package/mp4v2/mp4v2.hash |  2 ++
 package/mp4v2/mp4v2.mk   | 19 +++++++++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 package/mp4v2/Config.in
 create mode 100644 package/mp4v2/mp4v2.hash
 create mode 100644 package/mp4v2/mp4v2.mk

Comments

Yann E. MORIN Oct. 19, 2014, 10:46 a.m. UTC | #1 
Jörg, All,

On 2014-10-16 09:43 +0200, Jörg Krause spake thusly:
> Signed-off-by: Jörg Krause <jkrause@posteo.de>
> diff --git a/package/mp4v2/Config.in b/package/mp4v2/Config.in
> new file mode 100644
> index 0000000..bd0ddda
> --- /dev/null
> +++ b/package/mp4v2/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_MP4V2
> +	bool "mp4v2"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  The MP4v2 library provides functions to read, create, and modify mp4 files.

Keep the line below the 80-char limit, please.

> +
> +	  https://code.google.com/p/mp4v2/
> +
> +if BR2_PACKAGE_MP4V2
> +
> +config BR2_PACKAGE_MP4V2_UTIL
> +	bool "Install mp4 command line tools"
> +	help
> +	  Enable to install the mp4 command line tools mp4art, mp4chaps, mp4extract,

Ditto.

> +	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
> +
> +endif
> +
> +comment "mp4v2 needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/mp4v2/mp4v2.hash b/package/mp4v2/mp4v2.hash
> new file mode 100644
> index 0000000..d5a49c4
> --- /dev/null
> +++ b/package/mp4v2/mp4v2.hash
> @@ -0,0 +1,2 @@
> +# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
> +sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
> diff --git a/package/mp4v2/mp4v2.mk b/package/mp4v2/mp4v2.mk
> new file mode 100644
> index 0000000..b1f1740
> --- /dev/null
> +++ b/package/mp4v2/mp4v2.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# mp4v2
> +#
> +################################################################################
> +
> +MP4V2_VERSION = 2.0.0
> +MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
> +MP4V2_SITE = https://mp4v2.googlecode.com/files
> +MP4V2_INSTALL_STAGING = YES
> +MP4V2_LICENSE = MPLv1.1
> +MP4V2_LICENSE_FILES = COPYING
> +MP4V2_CONF_OPTS = --disable-debug

This will soone to be removed, as the pkg-autotools infrastructure will
soon be responsible for providing this.

> +
> +ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
> +MP4V2_CONF_OPTS += --disable-util
> +endif

We prefer using positive logic, and have the pending enable/disable
flags passed:

    ifeq ($(BR2_PACKAGE_MP4V2_UTIL),y)
    MP4V2_CONF_OPTS += --enable-util
    else
    MP4V2_CONF_OPTS += --disable-util
    endif

Regards,
Yann E. MORIN.

> +$(eval $(autotools-package))
> -- 
> 2.1.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Jörg Krause Oct. 20, 2014, 8:02 a.m. UTC | #2 
Hi Yann,

On 10/19/2014 12:46 PM, Yann E. MORIN wrote:
> Jörg, All,
>
> On 2014-10-16 09:43 +0200, Jörg Krause spake thusly:
>> Signed-off-by: Jörg Krause <jkrause@posteo.de>
>> diff --git a/package/mp4v2/Config.in b/package/mp4v2/Config.in
>> new file mode 100644
>> index 0000000..bd0ddda
>> --- /dev/null
>> +++ b/package/mp4v2/Config.in
>> @@ -0,0 +1,20 @@
>> +config BR2_PACKAGE_MP4V2
>> +	bool "mp4v2"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	help
>> +	  The MP4v2 library provides functions to read, create, and modify mp4 files.
> Keep the line below the 80-char limit, please.
>

I see! I guess the (default?) tab width for KConfig is 8 chars. I didn't 
find a definition for it. My editors tab width is 2 chars by default...

>> +	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
>> +
>> +endif
>> +
>> +comment "mp4v2 needs a toolchain w/ C++"
>> +	depends on !BR2_INSTALL_LIBSTDCPP
>> diff --git a/package/mp4v2/mp4v2.hash b/package/mp4v2/mp4v2.hash
>> new file mode 100644
>> index 0000000..d5a49c4
>> --- /dev/null
>> +++ b/package/mp4v2/mp4v2.hash
>> @@ -0,0 +1,2 @@
>> +# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
>> +sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
>> diff --git a/package/mp4v2/mp4v2.mk b/package/mp4v2/mp4v2.mk
>> new file mode 100644
>> index 0000000..b1f1740
>> --- /dev/null
>> +++ b/package/mp4v2/mp4v2.mk
>> @@ -0,0 +1,19 @@
>> +################################################################################
>> +#
>> +# mp4v2
>> +#
>> +################################################################################
>> +
>> +MP4V2_VERSION = 2.0.0
>> +MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
>> +MP4V2_SITE = https://mp4v2.googlecode.com/files
>> +MP4V2_INSTALL_STAGING = YES
>> +MP4V2_LICENSE = MPLv1.1
>> +MP4V2_LICENSE_FILES = COPYING
>> +MP4V2_CONF_OPTS = --disable-debug
> This will soone to be removed, as the pkg-autotools infrastructure will
> soon be responsible for providing this.

I see! So I can remove this here.

>
>> +
>> +ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
>> +MP4V2_CONF_OPTS += --disable-util
>> +endif
> We prefer using positive logic, and have the pending enable/disable
> flags passed:
>
>      ifeq ($(BR2_PACKAGE_MP4V2_UTIL),y)
>      MP4V2_CONF_OPTS += --enable-util
>      else
>      MP4V2_CONF_OPTS += --disable-util
>      endif

Looks good!

Many thanks for the review!
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 19bb9bf..819eaad 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -553,6 +553,7 @@  menu "Audio/Sound"
 	source "package/libsndfile/Config.in"
 	source "package/libsoxr/Config.in"
 	source "package/libvorbis/Config.in"
+	source "package/mp4v2/Config.in"
 	source "package/opencore-amr/Config.in"
 	source "package/opus/Config.in"
 	source "package/portaudio/Config.in"
diff --git a/package/mp4v2/Config.in b/package/mp4v2/Config.in
new file mode 100644
index 0000000..bd0ddda
--- /dev/null
+++ b/package/mp4v2/Config.in
@@ -0,0 +1,20 @@ 
+config BR2_PACKAGE_MP4V2
+	bool "mp4v2"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  The MP4v2 library provides functions to read, create, and modify mp4 files.
+
+	  https://code.google.com/p/mp4v2/
+
+if BR2_PACKAGE_MP4V2
+
+config BR2_PACKAGE_MP4V2_UTIL
+	bool "Install mp4 command line tools"
+	help
+	  Enable to install the mp4 command line tools mp4art, mp4chaps, mp4extract,
+	  mp4info, mp4subtitle, mp4tags, and mp4trackdump.
+
+endif
+
+comment "mp4v2 needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/mp4v2/mp4v2.hash b/package/mp4v2/mp4v2.hash
new file mode 100644
index 0000000..d5a49c4
--- /dev/null
+++ b/package/mp4v2/mp4v2.hash
@@ -0,0 +1,2 @@ 
+# From https://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2
+sha1 193260cfb7201e6ec250137bcca1468d4d20e2f0 mp4v2-2.0.0.tar.bz2
diff --git a/package/mp4v2/mp4v2.mk b/package/mp4v2/mp4v2.mk
new file mode 100644
index 0000000..b1f1740
--- /dev/null
+++ b/package/mp4v2/mp4v2.mk
@@ -0,0 +1,19 @@ 
+################################################################################
+#
+# mp4v2
+#
+################################################################################
+
+MP4V2_VERSION = 2.0.0
+MP4V2_SOURCE = mp4v2-$(MP4V2_VERSION).tar.bz2
+MP4V2_SITE = https://mp4v2.googlecode.com/files
+MP4V2_INSTALL_STAGING = YES
+MP4V2_LICENSE = MPLv1.1
+MP4V2_LICENSE_FILES = COPYING
+MP4V2_CONF_OPTS = --disable-debug
+
+ifneq ($(BR2_PACKAGE_MP4V2_UTIL),y)
+MP4V2_CONF_OPTS += --disable-util
+endif
+
+$(eval $(autotools-package))