diff mbox

[v2,5/5] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect

Message ID 1413367839-30999-7-git-send-email-kraxel@redhat.com
State New
Headers show

Commit Message

Gerd Hoffmann Oct. 15, 2014, 10:10 a.m. UTC 
Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL.

Cc: qemu-stable@nongnu.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/vmware_vga.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Don Koch Oct. 16, 2014, 3:21 p.m. UTC | #1 
On Wed, 15 Oct 2014 12:10:39 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

> Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/vmware_vga.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
> index 1fc9641..7f3a9e6 100644
> --- a/hw/display/vmware_vga.c
> +++ b/hw/display/vmware_vga.c
> @@ -30,9 +30,7 @@
>  
>  #undef VERBOSE
>  #define HW_RECT_ACCEL
> -#if 0
>  #define HW_FILL_ACCEL
> -#endif
>  #define HW_MOUSE_ACCEL
>  
>  #include "vga_int.h"
> @@ -456,6 +454,10 @@ static inline void vmsvga_fill_rect(struct vmsvga_state_s *s,
>      uint8_t *src;
>      uint8_t col[4];
>  
> +    if (!vmsvga_verify_rect(surface, __func__, x, y, w, h)) {
> +        return;
> +    }
> +

Same issue as with vmsvga_copy_rect().

-d
diff mbox

Patch

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 1fc9641..7f3a9e6 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -30,9 +30,7 @@ 
 
 #undef VERBOSE
 #define HW_RECT_ACCEL
-#if 0
 #define HW_FILL_ACCEL
-#endif
 #define HW_MOUSE_ACCEL
 
 #include "vga_int.h"
@@ -456,6 +454,10 @@  static inline void vmsvga_fill_rect(struct vmsvga_state_s *s,
     uint8_t *src;
     uint8_t col[4];
 
+    if (!vmsvga_verify_rect(surface, __func__, x, y, w, h)) {
+        return;
+    }
+
     col[0] = c;
     col[1] = c >> 8;
     col[2] = c >> 16;