[v2] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail
diff mbox

Message ID 1413309277-32485-1-git-send-email-david.a.cohen@linux.intel.com
State Not Applicable
Headers show

Commit Message

David Cohen Oct. 14, 2014, 5:54 p.m. UTC
Even if a gpio pin is set to output, we still need to set INPUT_EN
functionality (by clearing INPUT_EN bit) to be able to read the pin's
level.

E.g. without this change, we'll always read low level state from sysfs.

Cc: <stable@vger.kernel.org> # v3.14+
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---

v1 to v2: improved patch's body description as requested by Felipe Balbi
---

 drivers/pinctrl/pinctrl-baytrail.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felipe Balbi Oct. 14, 2014, 6:19 p.m. UTC | #1
On Tue, Oct 14, 2014 at 10:54:37AM -0700, David Cohen wrote:
> Even if a gpio pin is set to output, we still need to set INPUT_EN
> functionality (by clearing INPUT_EN bit) to be able to read the pin's
> level.
> 
> E.g. without this change, we'll always read low level state from sysfs.
> 
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
> 
> v1 to v2: improved patch's body description as requested by Felipe Balbi
> ---
> 
>  drivers/pinctrl/pinctrl-baytrail.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> index e12e5b07f6d7..c23d8ded936d 100644
> --- a/drivers/pinctrl/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/pinctrl-baytrail.c
> @@ -318,7 +318,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip,
>  		"Potential Error: Setting GPIO with direct_irq_en to output");
>  
>  	reg_val = readl(reg) | BYT_DIR_MASK;
> -	reg_val &= ~BYT_OUTPUT_EN;
> +	reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN);
>  
>  	if (value)
>  		writel(reg_val | BYT_LEVEL, reg);
> -- 
> 2.1.0
>
Linus Walleij Oct. 28, 2014, 10:17 a.m. UTC | #2
On Tue, Oct 14, 2014 at 7:54 PM, David Cohen
<david.a.cohen@linux.intel.com> wrote:

> Even if a gpio pin is set to output, we still need to set INPUT_EN
> functionality (by clearing INPUT_EN bit) to be able to read the pin's
> level.
>
> E.g. without this change, we'll always read low level state from sysfs.
>
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
>
> v1 to v2: improved patch's body description as requested by Felipe Balbi

This v2 version applied for fixes with Felipe's review tag.

Sorry for slow catching up with email :(

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
index e12e5b07f6d7..c23d8ded936d 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -318,7 +318,7 @@  static int byt_gpio_direction_output(struct gpio_chip *chip,
 		"Potential Error: Setting GPIO with direct_irq_en to output");
 
 	reg_val = readl(reg) | BYT_DIR_MASK;
-	reg_val &= ~BYT_OUTPUT_EN;
+	reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN);
 
 	if (value)
 		writel(reg_val | BYT_LEVEL, reg);