| Message ID | 20091202003629.4342710080C@ozlabs.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: > In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() > instead of ap->ops->bmdma_stop(). This can be a problem for controllers > that use their own bmdma_stop for which the generic sff one isn't suitable > > Signed-off-by: Benjamin Herrenschmidt<benh@kernel.crashing.org> > --- > > drivers/ata/libata-sff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 17:48:27.000000000 +1100 > +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 17:48:48.000000000 +1100 > @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at > ap->hsm_task_state = HSM_ST_IDLE; > > if (ap->ioaddr.bmdma_addr) > - ata_bmdma_stop(qc); > + ap->ops->bmdma_stop(qc); > > spin_unlock_irqrestore(ap->lock, flags); applied As we discussed, feel free to carry this in your tree as well. git should be able to sort it out. Acked-by: Jeff Garzik <jgarzik@redhat.com>
--- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 17:48:27.000000000 +1100 +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 17:48:48.000000000 +1100 @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at ap->hsm_task_state = HSM_ST_IDLE; if (ap->ioaddr.bmdma_addr) - ata_bmdma_stop(qc); + ap->ops->bmdma_stop(qc); spin_unlock_irqrestore(ap->lock, flags); }
In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap->ops->bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- drivers/ata/libata-sff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)