diff mbox

[2/3] asm/gpio.h: support gpio_to_irq()

Message ID 1259700494-17869-2-git-send-email-jacmet@sunsite.dk (mailing list archive)
State Accepted, archived
Commit 78331aded913d76c7ff996a1a0747d54b057460b
Delegated to: Kumar Gala
Headers show

Commit Message

Peter Korsgaard Dec. 1, 2009, 8:48 p.m. UTC
gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's
safe to always call.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 arch/powerpc/include/asm/gpio.h |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

Comments

Peter Korsgaard Dec. 9, 2009, 7:32 a.m. UTC | #1
>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:

 Peter> gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's
 Peter> safe to always call.

Comments?

 Peter> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
 Peter> ---
 Peter>  arch/powerpc/include/asm/gpio.h |    5 +----
 Peter>  1 files changed, 1 insertions(+), 4 deletions(-)

 Peter> diff --git a/arch/powerpc/include/asm/gpio.h b/arch/powerpc/include/asm/gpio.h
 Peter> index ea04632..38762ed 100644
 Peter> --- a/arch/powerpc/include/asm/gpio.h
 Peter> +++ b/arch/powerpc/include/asm/gpio.h
 Peter> @@ -38,12 +38,9 @@ static inline int gpio_cansleep(unsigned int gpio)
 Peter>  	return __gpio_cansleep(gpio);
 Peter>  }
 
 Peter> -/*
 Peter> - * Not implemented, yet.
 Peter> - */
 Peter>  static inline int gpio_to_irq(unsigned int gpio)
 Peter>  {
 Peter> -	return -ENOSYS;
 Peter> +	return __gpio_to_irq(gpio);
 Peter>  }
 
 Peter>  static inline int irq_to_gpio(unsigned int irq)
 Peter> -- 
 Peter> 1.6.5
Kumar Gala Dec. 11, 2009, 2:09 a.m. UTC | #2
On Dec 1, 2009, at 2:48 PM, Peter Korsgaard wrote:

> gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's
> safe to always call.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> arch/powerpc/include/asm/gpio.h |    5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)

applied to next

- k
diff mbox

Patch

diff --git a/arch/powerpc/include/asm/gpio.h b/arch/powerpc/include/asm/gpio.h
index ea04632..38762ed 100644
--- a/arch/powerpc/include/asm/gpio.h
+++ b/arch/powerpc/include/asm/gpio.h
@@ -38,12 +38,9 @@  static inline int gpio_cansleep(unsigned int gpio)
 	return __gpio_cansleep(gpio);
 }
 
-/*
- * Not implemented, yet.
- */
 static inline int gpio_to_irq(unsigned int gpio)
 {
-	return -ENOSYS;
+	return __gpio_to_irq(gpio);
 }
 
 static inline int irq_to_gpio(unsigned int irq)