| Message ID | 1413137610-21887-3-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Superseded |
| Headers | show |
Dear Bernd Kuhls, On Sun, 12 Oct 2014 20:13:25 +0200, Bernd Kuhls wrote: > tvheadend does not use autoconf but its configure script behaves as such. > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/tvheadend/tvheadend.mk | 27 ++++++--------------------- > 1 file changed, 6 insertions(+), 21 deletions(-) I generally dislike this approach. The fact that a non-autoconf configure script currently behaves sufficiently closely to an autoconf configure script is just pure happenstance, and any change to the pkg-autotools infrastructure may break this fragile assumption. So in general, I prefer non-autoconf packages to be handled with generic-package. Thomas
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:20141012213417.0ecdc736@free-electrons.com: Hi Thomas, > So in general, I prefer non-autoconf packages to be handled with > generic-package. ok, I removed the patch from v2. Regards, Bernd
diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk index 1445838..25a732c 100644 --- a/package/tvheadend/tvheadend.mk +++ b/package/tvheadend/tvheadend.mk @@ -20,26 +20,11 @@ endif TVHEADEND_DEPENDENCIES += dtv-scan-tables -define TVHEADEND_CONFIGURE_CMDS - (cd $(@D); \ - $(TARGET_CONFIGURE_OPTS) \ - $(TARGET_CONFIGURE_ARGS) \ - ./configure \ - --prefix=/usr \ - --arch="$(ARCH)" \ - --cpu="$(BR2_GCC_TARGET_CPU)" \ - --python="$(HOST_DIR)/usr/bin/python" \ - --disable-dvbscan \ - ) -endef - -define TVHEADEND_BUILD_CMDS - $(MAKE) -C $(@D) -endef - -define TVHEADEND_INSTALL_TARGET_CMDS - $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install -endef +TVHEADEND_CONF_OPTS += \ + --arch="$(ARCH)" \ + --cpu="$(BR2_GCC_TARGET_CPU)" \ + --python="$(HOST_DIR)/usr/bin/python" \ + --disable-dvbscan #---------------------------------------------------------------------------- # To run tvheadend, we need: @@ -62,4 +47,4 @@ define TVHEADEND_USERS tvheadend -1 tvheadend -1 * /home/tvheadend - video TVHeadend daemon endef -$(eval $(generic-package)) +$(eval $(autotools-package))
tvheadend does not use autoconf but its configure script behaves as such. Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/tvheadend/tvheadend.mk | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-)