diff mbox

[U-Boot,v3,6/6] sunxi: Kconfig: Unify sunxi Kconfig code

Message ID 1413137238-27251-7-git-send-email-hdegoede@redhat.com
State Accepted
Headers show

Commit Message

Hans de Goede Oct. 12, 2014, 6:07 p.m. UTC 
Unify the sunxi Kconfig code, instead of having seperate code blocks for
each of sun4i, sun5i and sun7i.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 board/sunxi/Kconfig | 32 +++++---------------------------
 1 file changed, 5 insertions(+), 27 deletions(-)

Comments

Ian Campbell Oct. 12, 2014, 9:17 p.m. UTC | #1 
On Sun, 2014-10-12 at 20:07 +0200, Hans de Goede wrote:
> Unify the sunxi Kconfig code, instead of having seperate code blocks for

"separate"

> each of sun4i, sun5i and sun7i.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Looks pretty familiar ;-)

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> ---
>  board/sunxi/Kconfig | 32 +++++---------------------------
>  1 file changed, 5 insertions(+), 27 deletions(-)
> 
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 552fce8..4ac562c 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -1,33 +1,11 @@
> -if TARGET_SUN4I
> -
> -config SYS_CONFIG_NAME
> -	default "sun4i"
> -
> -endif
> -
> -if TARGET_SUN5I
> -
> -config SYS_CONFIG_NAME
> -	default "sun5i"
> -
> -endif
> -
> -if TARGET_SUN6I
> +if TARGET_SUN4I || TARGET_SUN5I || TARGET_SUN6I || TARGET_SUN7I
>  
>  config SYS_CONFIG_NAME
>  	string
> -	default "sun6i"
> -
> -endif
> -
> -if TARGET_SUN7I
> -
> -config SYS_CONFIG_NAME
> -	default "sun7i"
> -
> -endif
> -
> -if TARGET_SUN4I || TARGET_SUN5I || TARGET_SUN6I || TARGET_SUN7I
> +	default "sun4i" if TARGET_SUN4I
> +	default "sun5i" if TARGET_SUN5I
> +	default "sun6i" if TARGET_SUN5I
> +	default "sun7i" if TARGET_SUN7I
>  
>  config SYS_CPU
>  	default "armv7"
diff mbox

Patch

diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
index 552fce8..4ac562c 100644
--- a/board/sunxi/Kconfig
+++ b/board/sunxi/Kconfig
@@ -1,33 +1,11 @@ 
-if TARGET_SUN4I
-
-config SYS_CONFIG_NAME
-	default "sun4i"
-
-endif
-
-if TARGET_SUN5I
-
-config SYS_CONFIG_NAME
-	default "sun5i"
-
-endif
-
-if TARGET_SUN6I
+if TARGET_SUN4I || TARGET_SUN5I || TARGET_SUN6I || TARGET_SUN7I
 
 config SYS_CONFIG_NAME
 	string
-	default "sun6i"
-
-endif
-
-if TARGET_SUN7I
-
-config SYS_CONFIG_NAME
-	default "sun7i"
-
-endif
-
-if TARGET_SUN4I || TARGET_SUN5I || TARGET_SUN6I || TARGET_SUN7I
+	default "sun4i" if TARGET_SUN4I
+	default "sun5i" if TARGET_SUN5I
+	default "sun6i" if TARGET_SUN5I
+	default "sun7i" if TARGET_SUN7I
 
 config SYS_CPU
 	default "armv7"