diff mbox

snowball-hdmiservice: Use github call

Message ID 1413136827-31792-1-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Commit b05963181a2402e446e4a917fc4e7ad655ba6978
Headers show

Commit Message

Maxime Hadjinlian Oct. 12, 2014, 6 p.m. UTC
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/snowball-hdmiservice/snowball-hdmiservice.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Oct. 24, 2014, 11:57 p.m. UTC | #1
Maxime, All,

On 2014-10-12 20:00 +0200, Maxime Hadjinlian spake thusly:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Note: this patch also removes trailing spaces+tab, which is not readily
visible in a mail, you should have stated so in the commit log, somethig
like:

    Also get rid of traling spaces+tabs.

Regards,
Yann E. MORIN.

> ---
>  package/snowball-hdmiservice/snowball-hdmiservice.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/snowball-hdmiservice/snowball-hdmiservice.mk b/package/snowball-hdmiservice/snowball-hdmiservice.mk
> index f254414..267b5ad 100644
> --- a/package/snowball-hdmiservice/snowball-hdmiservice.mk
> +++ b/package/snowball-hdmiservice/snowball-hdmiservice.mk
> @@ -5,13 +5,13 @@
>  ################################################################################
>  
>  SNOWBALL_HDMISERVICE_VERSION = f75c99d1c52707240a78b4ba78e41d20d3aa3b08
> -SNOWBALL_HDMISERVICE_SITE = https://github.com/igloocommunity/hdmiservice
> +SNOWBALL_HDMISERVICE_SITE = $(call github,igloocommunity,hdmiservice,$(SNOWBALL_HDMISERVICE_VERSION))
>  SNOWBALL_HDMISERVICE_LICENSE = MIT
>  SNOWBALL_HDMISERVICE_LICENSE_FILES = debian/copyright
>  SNOWBALL_HDMISERVICE_INSTALL_STAGING = YES
>  
>  define SNOWBALL_HDMISERVICE_BUILD_CMDS
> -	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)" 	
> +	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
>  endef
>  
>  define SNOWBALL_HDMISERVICE_INSTALL_STAGING_CMDS
> -- 
> 2.1.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Oct. 25, 2014, 12:04 a.m. UTC | #2
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/snowball-hdmiservice/snowball-hdmiservice.mk b/package/snowball-hdmiservice/snowball-hdmiservice.mk
index f254414..267b5ad 100644
--- a/package/snowball-hdmiservice/snowball-hdmiservice.mk
+++ b/package/snowball-hdmiservice/snowball-hdmiservice.mk
@@ -5,13 +5,13 @@ 
 ################################################################################
 
 SNOWBALL_HDMISERVICE_VERSION = f75c99d1c52707240a78b4ba78e41d20d3aa3b08
-SNOWBALL_HDMISERVICE_SITE = https://github.com/igloocommunity/hdmiservice
+SNOWBALL_HDMISERVICE_SITE = $(call github,igloocommunity,hdmiservice,$(SNOWBALL_HDMISERVICE_VERSION))
 SNOWBALL_HDMISERVICE_LICENSE = MIT
 SNOWBALL_HDMISERVICE_LICENSE_FILES = debian/copyright
 SNOWBALL_HDMISERVICE_INSTALL_STAGING = YES
 
 define SNOWBALL_HDMISERVICE_BUILD_CMDS
-	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)" 	
+	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
 endef
 
 define SNOWBALL_HDMISERVICE_INSTALL_STAGING_CMDS