diff mbox

eudev: improve S10udev script for startup

Message ID 1413098527-17162-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit df8ae412a44ec21d9928e8ba753adee7207d02bc
Headers show

Commit Message

Thomas Petazzoni Oct. 12, 2014, 7:22 a.m. UTC 
From: Paul Cercueil <paul@crapouillou.net>

This commit adjusts the S10udev script by:

 * Using the --action=add option to udevadm trigger. By default, only
   the "change" events are handled by 'udevadm trigger', which means
   it doesn't handle all the "device add" events that occured during
   the boot time, before eudev was started.

 * Adds a call to 'udevadm settle' to make sure we wait for udev to
   handle all the events that occured before eudev was started.

Both of these change match what the Ubuntu and Debian udev startup
scripts are doing.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/eudev/S10udev | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard Oct. 12, 2014, 7:27 a.m. UTC | #1 
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > From: Paul Cercueil <paul@crapouillou.net>
 > This commit adjusts the S10udev script by:

 >  * Using the --action=add option to udevadm trigger. By default, only
 >    the "change" events are handled by 'udevadm trigger', which means
 >    it doesn't handle all the "device add" events that occured during
 >    the boot time, before eudev was started.

 >  * Adds a call to 'udevadm settle' to make sure we wait for udev to
 >    handle all the events that occured before eudev was started.

 > Both of these change match what the Ubuntu and Debian udev startup
 > scripts are doing.

 > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/eudev/S10udev b/package/eudev/S10udev
index e00aa91..107dfd5 100755
--- a/package/eudev/S10udev
+++ b/package/eudev/S10udev
@@ -30,7 +30,8 @@  case "$1" in
         printf "Populating ${udev_root:-/dev} using udev: "
         printf '\000\000\000\000' > /proc/sys/kernel/hotplug
         $UDEV_BIN -d || (echo "FAIL" && exit 1)
-        udevadm trigger
+        udevadm trigger --action=add
+        udevadm settle
         echo "done"
         ;;
     stop)