From patchwork Tue Dec 1 05:57:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 39876 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DA9C81007D2 for ; Tue, 1 Dec 2009 16:58:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbZLAF62 (ORCPT ); Tue, 1 Dec 2009 00:58:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752755AbZLAF62 (ORCPT ); Tue, 1 Dec 2009 00:58:28 -0500 Received: from gate.crashing.org ([63.228.1.57]:53670 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752294AbZLAF62 (ORCPT ); Tue, 1 Dec 2009 00:58:28 -0500 Received: from [IPv6:::1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id nB15vs8k012312; Mon, 30 Nov 2009 23:57:55 -0600 Subject: Re: libata hotplug question From: Benjamin Herrenschmidt To: Tejun Heo Cc: linux-ide@vger.kernel.org In-Reply-To: <1259645941.2076.225.camel@pasglop> References: <1259561052.2076.73.camel@pasglop> <1259624651.2076.158.camel@pasglop> <4B1459B5.40504@kernel.org> <1259635420.2076.180.camel@pasglop> <1259644647.2076.204.camel@pasglop> <4B14A809.8000304@kernel.org> <1259645409.2076.213.camel@pasglop> <4B14AAD0.4060806@kernel.org> <1259645941.2076.225.camel@pasglop> Date: Tue, 01 Dec 2009 16:57:53 +1100 Message-ID: <1259647073.2076.247.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, 2009-12-01 at 16:39 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2009-12-01 at 14:34 +0900, Tejun Heo wrote: > > In effect, they would be the same but if the hotplug notification can > > be made reliable, I think using DFLAG_DETACH would be better as > > there's already other users doing that (user requested detach and ACPI > > dock removal). > > Allright. I just need to find how to tell it at boot that it's detached > to avoid time probing a non existing interface but that's no big deal. No point bothering, it looks like it picks up the ff's at boot just fine like an unpopulated interface and things just work without any spurrious delay. I'll do a few more tests and will send the patches for review. Note that I had to do one change to libata-sff: I'll include that change in my patch series. Cheers, Ben. --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 16:51:10.000000000 +1100 +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 16:52:59.000000000 +1100 @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at ap->hsm_task_state = HSM_ST_IDLE; if (ap->ioaddr.bmdma_addr) - ata_bmdma_stop(qc); + ap->ops->bmdma_stop(qc); spin_unlock_irqrestore(ap->lock, flags);