Patchwork libata hotplug question

login
register
mail settings
Submitter Benjamin Herrenschmidt
Date Dec. 1, 2009, 5:57 a.m.
Message ID <1259647073.2076.247.camel@pasglop>
Download mbox | patch
Permalink /patch/39876/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Benjamin Herrenschmidt - Dec. 1, 2009, 5:57 a.m.
On Tue, 2009-12-01 at 16:39 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2009-12-01 at 14:34 +0900, Tejun Heo wrote:
> > In effect, they would be the same but if the hotplug notification can
> > be made reliable, I think using DFLAG_DETACH would be better as
> > there's already other users doing that (user requested detach and ACPI
> > dock removal). 
> 
> Allright. I just need to find how to tell it at boot that it's detached
> to avoid time probing a non existing interface but that's no big deal.

No point bothering, it looks like it picks up the ff's at boot just fine
like an unpopulated interface and things just work without any spurrious
delay.

I'll do a few more tests and will send the patches for review.

Note that I had to do one change to libata-sff:

I'll include that change in my patch series.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-work.orig/drivers/ata/libata-sff.c	2009-12-01 16:51:10.000000000 +1100
+++ linux-work/drivers/ata/libata-sff.c	2009-12-01 16:52:59.000000000 +1100
@@ -2384,7 +2384,7 @@  void ata_sff_post_internal_cmd(struct at
 	ap->hsm_task_state = HSM_ST_IDLE;
 
 	if (ap->ioaddr.bmdma_addr)
-		ata_bmdma_stop(qc);
+		ap->ops->bmdma_stop(qc);
 
 	spin_unlock_irqrestore(ap->lock, flags);