From patchwork Mon Nov 30 14:48:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 39807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 38A15B7B3E for ; Tue, 1 Dec 2009 01:53:12 +1100 (EST) Received: from localhost ([127.0.0.1]:52170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7cj-0001aM-Mi for incoming@patchwork.ozlabs.org; Mon, 30 Nov 2009 09:53:09 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF7bM-0001Ac-P4 for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:51:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF7bI-00018R-3Z for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:51:44 -0500 Received: from [199.232.76.173] (port=39430 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7bH-00018J-QR for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:51:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61578) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF7bH-00013K-DD for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:51:39 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAUEpZFQ002285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Nov 2009 09:51:35 -0500 Received: from redhat.com (vpn-6-53.tlv.redhat.com [10.35.6.53]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id nAUEpWNf003797; Mon, 30 Nov 2009 09:51:33 -0500 Date: Mon, 30 Nov 2009 16:48:55 +0200 From: "Michael S. Tsirkin" To: Avi Kivity Message-ID: <20091130144855.GB30802@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela Subject: [Qemu-devel] [PATCHv4-repost 1/2] qemu: make cirrus init value pci spec compliant X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org PCI memory should be disabled at reset, otherwise we might claim transactions at address 0. I/O should also be disabled, although for cirrus it is harmless to enable it as we do not have I/O bar. Note: bios fix needed for this patch to work was already applied: previously bios incorrently assumed that it does not need to enable i/o unless device has i/o bar. Signed-off-by: Michael S. Tsirkin --- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 9390d2c..89ffdf9 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3249,7 +3249,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) /* setup PCI */ pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS); pci_config_set_device_id(pci_conf, device_id); - pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS; pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA); pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL;