diff mbox

C++ PATCH for c++/63485

Message ID 5435E9A3.7090207@redhat.com
State New
Headers show

Commit Message

Jason Merrill Oct. 9, 2014, 1:49 a.m. UTC 
My recent change to build_cplus_array_type failed to consider typedef 
variants.

Tested x86_64-pc-linux-gnu, applying to trunk.
diff mbox

Patch

commit f28aac3ccf4b8d4ecea7f34a37dc18ff1a45649a
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Oct 8 12:19:38 2014 -0400

    	PR c++/63485
    	* tree.c (build_cplus_array_type): Look for a type with no
    	typedef-name or attributes.

diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index cfb0ed8..5b11d5c 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -853,7 +853,9 @@  build_cplus_array_type (tree elt_type, tree index_type)
     {
       tree m = t;
       for (t = m; t; t = TYPE_NEXT_VARIANT (t))
-	if (TREE_TYPE (t) == elt_type)
+	if (TREE_TYPE (t) == elt_type
+	    && TYPE_NAME (t) == NULL_TREE
+	    && TYPE_ATTRIBUTES (t) == NULL_TREE)
 	  break;
       if (!t)
 	{
diff --git a/gcc/testsuite/g++.dg/template/array29.C b/gcc/testsuite/g++.dg/template/array29.C
new file mode 100644
index 0000000..e43cb9d
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/array29.C
@@ -0,0 +1,56 @@ 
+// PR c++/63485
+
+template <typename C> struct A
+{
+  typedef C type;
+};
+template <class> class B
+{
+};
+template <class Range> void as_literal (Range &);
+template <typename> struct C
+{
+  typedef wchar_t char_type;
+  const char_type on_full_year_placeholder[3];
+  void
+  on_extended_iso_date ()
+  {
+    B<A<wchar_t const[3]>::type> a;
+    as_literal (on_full_year_placeholder);
+  }
+};
+template <typename> struct date_time_format_parser_callback : C<wchar_t>
+{
+};
+template <typename BaseT> struct D
+{
+  typedef typename BaseT::char_type char_type;
+  char_type
+  parse (const char_type *, const char_type *,
+         typename BaseT::callback_type p3)
+  {
+    p3.on_extended_iso_date ();
+  }
+};
+struct F
+{
+  typedef date_time_format_parser_callback<wchar_t> callback_type;
+  typedef wchar_t char_type;
+};
+template <typename CharT, typename ParserT, typename CallbackT>
+void
+parse_format (CharT *p1, ParserT p2, CallbackT p3)
+{
+  CharT p = p2.parse (&p, p1, p3);
+}
+template <typename CharT>
+void
+parse_date_time_format (const CharT *, const CharT *p2,
+                        date_time_format_parser_callback<CharT> &p3)
+{
+  D<F> b;
+  parse_format (p2, b, p3);
+}
+template void
+parse_date_time_format (const wchar_t *, const wchar_t *,
+                        date_time_format_parser_callback<wchar_t> &);