| Message ID | 20091130035616.GA15493@serverengines.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Ajit Khaparde <ajitk@serverengines.com> Date: Mon, 30 Nov 2009 09:26:26 +0530 > Allow only valid ether addresses to be assigned and used for the interface. > > Signed-off-by: Ajit Khaparde <ajitk@serverengines.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index e24f498..10262fa 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -125,6 +125,9 @@ static int be_mac_addr_set(struct net_device *netdev, void *p) struct sockaddr *addr = p; int status = 0; + if (!is_valid_ether_addr(addr->sa_data)) + return -EADDRNOTAVAIL; + status = be_cmd_pmac_del(adapter, adapter->if_handle, adapter->pmac_id); if (status) return status; @@ -2146,6 +2149,10 @@ static int be_get_config(struct be_adapter *adapter) MAC_ADDRESS_TYPE_NETWORK, true /*permanent */, 0); if (status) return status; + + if (!is_valid_ether_addr(mac)) + return -EADDRNOTAVAIL; + memcpy(adapter->netdev->dev_addr, mac, ETH_ALEN); memcpy(adapter->netdev->perm_addr, mac, ETH_ALEN);
Allow only valid ether addresses to be assigned and used for the interface. Signed-off-by: Ajit Khaparde <ajitk@serverengines.com> --- drivers/net/benet/be_main.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)