diff mbox

[1/2] package/sysvinit: don't start logging

Message ID 1412779165-13366-1-git-send-email-gustavo@zacarias.com.ar
State Accepted
Commit d61c8d73d409f4df6162fb32a02617360e4a02e6
Headers show

Commit Message

Gustavo Zacarias Oct. 8, 2014, 2:39 p.m. UTC
Don't try to start logging from /etc/inittab because busybox installs a
S01logging script that handles that and can lead to duplicate logging
processes.
Let's handle the logging in each package that provides it since we can
get multiple variants in the future like syslog-ng that have different
initialization routines.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/sysvinit/inittab | 7 -------
 1 file changed, 7 deletions(-)

Comments

Markos Chandras Oct. 8, 2014, 3:02 p.m. UTC | #1
On 10/08/2014 03:39 PM, Gustavo Zacarias wrote:
> Don't try to start logging from /etc/inittab because busybox installs a
> S01logging script that handles that and can lead to duplicate logging
> processes.
> Let's handle the logging in each package that provides it since we can
> get multiple variants in the future like syslog-ng that have different
> initialization routines.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---

Thanks. That has always been bugging me but never got around to fix it
myself

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Peter Korsgaard Oct. 12, 2014, 11:02 a.m. UTC | #2
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > Don't try to start logging from /etc/inittab because busybox installs a
 > S01logging script that handles that and can lead to duplicate logging
 > processes.
 > Let's handle the logging in each package that provides it since we can
 > get multiple variants in the future like syslog-ng that have different
 > initialization routines.

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Committed, thanks.
diff mbox

Patch

diff --git a/package/sysvinit/inittab b/package/sysvinit/inittab
index 8812cca..d3de4a7 100644
--- a/package/sysvinit/inittab
+++ b/package/sysvinit/inittab
@@ -17,16 +17,9 @@  init::sysinit:/etc/init.d/rcS
 
 # S0:1:respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
 
-# Logging junk
-mess::sysinit:/bin/touch /var/log/messages
-sysl:1:respawn:/sbin/syslogd -n -m 0
-klog:1:respawn:/sbin/klogd -n
-
 # Stuff to do for the 3-finger salute
 rebo::ctrlaltdel:/sbin/reboot
 
 # Stuff to do before rebooting
-sklo:6:wait:/usr/bin/killall klogd
-ssys:6:wait:/usr/bin/killall syslogd
 umou:6:wait:/bin/umount -a -r
 swap:6:wait:/sbin/swapoff -a