| Message ID | 1412619987.11091.76.camel@edumazet-glaptop2.roam.corp.google.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@google.com> > > Marking this as static allows compiler to inline it. Found by inspection or another tool? Wasn't there some tool to look for non-static functions that are not called externally that could/should be converted to static? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 06, 2014 at 11:44:02AM -0700, Joe Perches wrote: > On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote: > > From: Eric Dumazet <edumazet@google.com> > > > > Marking this as static allows compiler to inline it. > > Found by inspection or another tool? > > Wasn't there some tool to look for non-static functions > that are not called externally that could/should be > converted to static? Several: sparse, gcc -Wmissing-prototypes, and findstatic.pl. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-10-06 at 11:44 -0700, Joe Perches wrote: > On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote: > > From: Eric Dumazet <edumazet@google.com> > > > > Marking this as static allows compiler to inline it. > > Found by inspection or another tool? > > Wasn't there some tool to look for non-static functions > that are not called externally that could/should be > converted to static? Found by inspecting and analyzing performance on real workload. Note prior commits : bec3cfdca36bf43cfa3751ad7b56db1a307e0760 net: skb_segment() provides list head and tail 01291202ed4ad548f9a7147d20425cb1d24f49a7 net: do not export skb_gro_receive() 55a93b3ea780908b7d1b3a8cf1976223a9268d78 qdisc: validate skb without holding lock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-10-06 at 12:07 -0700, Josh Triplett wrote: > On Mon, Oct 06, 2014 at 11:44:02AM -0700, Joe Perches wrote: > > On Mon, 2014-10-06 at 11:26 -0700, Eric Dumazet wrote: > > > From: Eric Dumazet <edumazet@google.com> > > > > > > Marking this as static allows compiler to inline it. > > > > Found by inspection or another tool? > > > > Wasn't there some tool to look for non-static functions > > that are not called externally that could/should be > > converted to static? > > Several: sparse, Doesn't find anything for this use case > gcc -Wmissing-prototypes, and findstatic.pl. Right, thanks, using "make W=1" adds -Wmissing-prototypes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Mon, 06 Oct 2014 11:26:27 -0700 > From: Eric Dumazet <edumazet@google.com> > > Marking this as static allows compiler to inline it. > > Signed-off-by: Eric Dumazet <edumazet@google.com> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 7d5691cc1f479ee4f1bb46b06d35fe8c..2702724ce2de5712e13c37321597a314 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2643,7 +2643,8 @@ out: return skb; } -struct sk_buff *validate_xmit_vlan(struct sk_buff *skb, netdev_features_t features) +static struct sk_buff *validate_xmit_vlan(struct sk_buff *skb, + netdev_features_t features) { if (vlan_tx_tag_present(skb) && !vlan_hw_offload_capable(features, skb->vlan_proto)) {