diff mbox

[2/3] acpi: method: add check for _PRL

Message ID 1412584540-9528-2-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Oct. 6, 2014, 8:35 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

Comments

Colin Ian King Oct. 6, 2014, 8:43 a.m. UTC | #1
On 06/10/14 09:35, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index e6c5355..3ad9357 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -155,7 +155,7 @@
>   * _PR2  7.2.10		Y
>   * _PR3  7.2.11		Y
>   * _PRE  7.2.12		Y
> - * _PRL  10.3.4		N
> + * _PRL  10.3.4		Y
>   * _PRT  6.2.12		N
>   * _PRS  6.2.11		Y
>   * _PRW  7.2.11		N
> @@ -4324,6 +4324,30 @@ static int method_test_BMC(fwts_framework *fw)
>  /*
>   * Section 10.3 AC Adapters and Power Sources Objects
>   */
> +static void method_test_PRL_return(
> +	fwts_framework *fw,
> +	char *name,
> +	ACPI_BUFFER *buf,
> +	ACPI_OBJECT *obj,
> +	void *private)
> +{
> +	FWTS_UNUSED(private);
> +
> +	if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) != FWTS_OK)
> +		return;
> +
> +	if (method_package_elements_all_type(fw, name, "_PRL", obj, ACPI_TYPE_LOCAL_REFERENCE) != FWTS_OK)
> +		return;
> +
> +	method_passed_sane(fw, name, "package");
> +}
> +
> +static int method_test_PRL(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_PRL", NULL, 0, method_test_PRL_return, NULL);
> +}
> +
>  static void method_test_PSR_return(
>  	fwts_framework *fw,
>  	char *name,
> @@ -5709,7 +5733,7 @@ static fwts_framework_minor_test method_tests[] = {
>  
>  	{ method_test_PCL, "Test _PCL (Power Consumer List)." },
>  	{ method_test_PIF, "Test _PIF (Power Source Information)." },
> -	/* { method_test_PRL, "Test _PRL (Power Source Redundancy List)." }, */
> +	{ method_test_PRL, "Test _PRL (Power Source Redundancy List)." },
>  	{ method_test_PSR, "Test _PSR (Power Source)." },
>  
>  	/* Section 10.4 Power Meters */
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Oct. 15, 2014, 7:21 a.m. UTC | #2
On Mon, Oct 6, 2014 at 4:35 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index e6c5355..3ad9357 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -155,7 +155,7 @@
>   * _PR2  7.2.10                Y
>   * _PR3  7.2.11                Y
>   * _PRE  7.2.12                Y
> - * _PRL  10.3.4                N
> + * _PRL  10.3.4                Y
>   * _PRT  6.2.12                N
>   * _PRS  6.2.11                Y
>   * _PRW  7.2.11                N
> @@ -4324,6 +4324,30 @@ static int method_test_BMC(fwts_framework *fw)
>  /*
>   * Section 10.3 AC Adapters and Power Sources Objects
>   */
> +static void method_test_PRL_return(
> +       fwts_framework *fw,
> +       char *name,
> +       ACPI_BUFFER *buf,
> +       ACPI_OBJECT *obj,
> +       void *private)
> +{
> +       FWTS_UNUSED(private);
> +
> +       if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) != FWTS_OK)
> +               return;
> +
> +       if (method_package_elements_all_type(fw, name, "_PRL", obj, ACPI_TYPE_LOCAL_REFERENCE) != FWTS_OK)
> +               return;
> +
> +       method_passed_sane(fw, name, "package");
> +}
> +
> +static int method_test_PRL(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_PRL", NULL, 0, method_test_PRL_return, NULL);
> +}
> +
>  static void method_test_PSR_return(
>         fwts_framework *fw,
>         char *name,
> @@ -5709,7 +5733,7 @@ static fwts_framework_minor_test method_tests[] = {
>
>         { method_test_PCL, "Test _PCL (Power Consumer List)." },
>         { method_test_PIF, "Test _PIF (Power Source Information)." },
> -       /* { method_test_PRL, "Test _PRL (Power Source Redundancy List)." }, */
> +       { method_test_PRL, "Test _PRL (Power Source Redundancy List)." },
>         { method_test_PSR, "Test _PSR (Power Source)." },
>
>         /* Section 10.4 Power Meters */
> --
> 1.9.1
>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index e6c5355..3ad9357 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -155,7 +155,7 @@ 
  * _PR2  7.2.10		Y
  * _PR3  7.2.11		Y
  * _PRE  7.2.12		Y
- * _PRL  10.3.4		N
+ * _PRL  10.3.4		Y
  * _PRT  6.2.12		N
  * _PRS  6.2.11		Y
  * _PRW  7.2.11		N
@@ -4324,6 +4324,30 @@  static int method_test_BMC(fwts_framework *fw)
 /*
  * Section 10.3 AC Adapters and Power Sources Objects
  */
+static void method_test_PRL_return(
+	fwts_framework *fw,
+	char *name,
+	ACPI_BUFFER *buf,
+	ACPI_OBJECT *obj,
+	void *private)
+{
+	FWTS_UNUSED(private);
+
+	if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) != FWTS_OK)
+		return;
+
+	if (method_package_elements_all_type(fw, name, "_PRL", obj, ACPI_TYPE_LOCAL_REFERENCE) != FWTS_OK)
+		return;
+
+	method_passed_sane(fw, name, "package");
+}
+
+static int method_test_PRL(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_PRL", NULL, 0, method_test_PRL_return, NULL);
+}
+
 static void method_test_PSR_return(
 	fwts_framework *fw,
 	char *name,
@@ -5709,7 +5733,7 @@  static fwts_framework_minor_test method_tests[] = {
 
 	{ method_test_PCL, "Test _PCL (Power Consumer List)." },
 	{ method_test_PIF, "Test _PIF (Power Source Information)." },
-	/* { method_test_PRL, "Test _PRL (Power Source Redundancy List)." }, */
+	{ method_test_PRL, "Test _PRL (Power Source Redundancy List)." },
 	{ method_test_PSR, "Test _PSR (Power Source)." },
 
 	/* Section 10.4 Power Meters */