diff mbox

[v2,08/16] package/apr-util: add optional dependency to openssl

Message ID 1412530744-20649-9-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Oct. 5, 2014, 5:38 p.m. UTC 
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/apr-util/apr-util.mk |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Thomas Petazzoni Oct. 5, 2014, 6:39 p.m. UTC | #1 
Dear Bernd Kuhls,

On Sun,  5 Oct 2014 19:38:56 +0200, Bernd Kuhls wrote:

> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +APR_UTIL_CONF_OPTS += --with-crypto --with-openssl="$(STAGING_DIR)/usr"
> +APR_UTIL_DEPENDENCIES += openssl
> +else
> +APR_UTIL_CONF_OPTS += --without-ssl
> +endif

This looks weird, because there's no symmetry between --with-openssl
--with-crypto and --without-ssl. Isn't there an issue here?

Thanks,

Thomas
Bernd Kuhls Oct. 5, 2014, 6:47 p.m. UTC | #2 
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141005203902.5d8c5dcf@free-electrons.com:

>> +APR_UTIL_CONF_OPTS += --without-ssl
>> +endif
> 
> This looks weird, because there's no symmetry between --with-openssl
> --with-crypto and --without-ssl. Isn't there an issue here?

Hi,

oops, without-ssl should have been without-crypto.

To enable OpenSSL support

a) --with-crypto is needed to enable the crypto stuff as such and
b) --with-openssl to enable the use of the OpenSSL library itself.

I will update this patch in v3, thanks!

Regards, Bernd
Bernd Kuhls Oct. 6, 2014, 7:33 p.m. UTC | #3 
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141005203902.5d8c5dcf@free-electrons.com:

> This looks weird, because there's no symmetry between --with-openssl
> --with-crypto and --without-ssl. Isn't there an issue here?

Hi Thomas,

I sent v3 of this patch: http://patchwork.ozlabs.org/patch/396912/
and superseeded the buggy version in patchworks.

Is it ok to only send a single patch and not the whole series again? This 
patch does not depend on the other patches of the apache/php series.

Regards, Bernd
diff mbox

Patch

diff --git a/package/apr-util/apr-util.mk b/package/apr-util/apr-util.mk
index 42506bb..ed8eb28 100644
--- a/package/apr-util/apr-util.mk
+++ b/package/apr-util/apr-util.mk
@@ -46,4 +46,11 @@  else
 APR_UTIL_CONF_OPTS += --without-sqlite3
 endif
 
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+APR_UTIL_CONF_OPTS += --with-crypto --with-openssl="$(STAGING_DIR)/usr"
+APR_UTIL_DEPENDENCIES += openssl
+else
+APR_UTIL_CONF_OPTS += --without-ssl
+endif
+
 $(eval $(autotools-package))