| Message ID | 1412358473-31398-39-git-send-email-dgilbert@redhat.com |
|---|---|
| State | New |
| Headers | show |
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > I've seen it go negative once during dev, it shouldn't > happen. You can move it earlier, perhaps even as patch 1, since it does not have any dependency on postcopy and can go in at any time. Paolo
* Paolo Bonzini (pbonzini@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > > > I've seen it go negative once during dev, it shouldn't > > happen. > > You can move it earlier, perhaps even as patch 1, since it does not have > any dependency on postcopy and can go in at any time. OK, I moved it to the 2nd patch - just after the docs (Eric previously said he liked those at the start of a patch set). Dave > > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Il 06/10/2014 20:51, Dr. David Alan Gilbert ha scritto: > * Paolo Bonzini (pbonzini@redhat.com) wrote: >> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: >>> >>> I've seen it go negative once during dev, it shouldn't >>> happen. >> >> You can move it earlier, perhaps even as patch 1, since it does not have >> any dependency on postcopy and can go in at any time. > > OK, I moved it to the 2nd patch - just after the docs (Eric previously said > he liked those at the start of a patch set). What about sending it for 2.2? Might as well package it up with Peter's flags patch and send a pull request, since Juan is busy and has hardly written to the list for several months now. Paolo
On Fri, Oct 03, 2014 at 06:47:44PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > I've seen it go negative once during dev, it shouldn't > happen. > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
diff --git a/arch_init.c b/arch_init.c index a945990..2f4345a 100644 --- a/arch_init.c +++ b/arch_init.c @@ -442,6 +442,7 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr, if (next < size) { clear_bit(next, migration_bitmap); + assert(migration_dirty_pages > 0); migration_dirty_pages--; } *bitoffset = next;