Patchwork [4/4] virtio-blk: Implement rerror option

login
register
mail settings
Submitter Kevin Wolf
Date Nov. 27, 2009, 12:25 p.m.
Message ID <1259324739-6805-5-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/39627/
State New
Headers show

Comments

Kevin Wolf - Nov. 27, 2009, 12:25 p.m.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/virtio-blk.c |   13 ++++++++-----
 vl.c            |    2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)

Patch

diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index a93d20d..a2f0639 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -98,9 +98,11 @@  static void virtio_blk_req_complete(VirtIOBlockReq *req, int status)
     qemu_free(req);
 }
 
-static int virtio_blk_handle_write_error(VirtIOBlockReq *req, int error)
+static int virtio_blk_handle_rw_error(VirtIOBlockReq *req, int error,
+    int is_read)
 {
-    BlockInterfaceErrorAction action = drive_get_on_error(req->dev->bs, 0);
+    BlockInterfaceErrorAction action =
+        drive_get_on_error(req->dev->bs, is_read);
     VirtIOBlock *s = req->dev;
 
     if (action == BLOCK_ERR_IGNORE)
@@ -122,12 +124,13 @@  static void virtio_blk_rw_complete(void *opaque, int ret)
 {
     VirtIOBlockReq *req = opaque;
 
-    if (ret && (req->out->type & VIRTIO_BLK_T_OUT)) {
-        if (virtio_blk_handle_write_error(req, -ret))
+    if (ret) {
+        int is_read = !(req->out->type & VIRTIO_BLK_T_OUT);
+        if (virtio_blk_handle_rw_error(req, -ret, is_read))
             return;
     }
 
-    virtio_blk_req_complete(req, ret ? VIRTIO_BLK_S_IOERR : VIRTIO_BLK_S_OK);
+    virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
 }
 
 static void virtio_blk_flush_complete(void *opaque, int ret)
diff --git a/vl.c b/vl.c
index 0136d16..9f3962c 100644
--- a/vl.c
+++ b/vl.c
@@ -2199,7 +2199,7 @@  DriveInfo *drive_init(QemuOpts *opts, void *opaque,
 
     on_read_error = BLOCK_ERR_REPORT;
     if ((buf = qemu_opt_get(opts, "rerror")) != NULL) {
-        if (type != IF_IDE) {
+        if (type != IF_IDE && type != IF_VIRTIO) {
             fprintf(stderr, "rerror is no supported by this format\n");
             return NULL;
         }