Patchwork eepro100: Improve debug messages

login
register
mail settings
Submitter Stefan Weil
Date Nov. 27, 2009, 11:06 a.m.
Message ID <1259319962-10683-1-git-send-email-weil@mail.berlios.de>
Download mbox | patch
Permalink /patch/39622/
State New
Headers show

Comments

Stefan Weil - Nov. 27, 2009, 11:06 a.m.
* buf was too small for longer register names.
* Use consistent upper case for nouns in register names.
* Use better name for array with e100 register names.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/eepro100.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/hw/eepro100.c b/hw/eepro100.c
index 8734907..4210d8a 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -635,22 +635,22 @@  static void nic_reset(void *opaque)
 }
 
 #if defined(DEBUG_EEPRO100)
-static const char * const reg[PCI_IO_SIZE / 4] = {
+static const char * const e100_reg[PCI_IO_SIZE / 4] = {
     "Command/Status",
     "General Pointer",
     "Port",
     "EEPROM/Flash Control",
     "MDI Control",
     "Receive DMA Byte Count",
-    "Flow control",
+    "Flow Control",
     "General Status/Control"
 };
 
 static char *regname(uint32_t addr)
 {
-    static char buf[16];
+    static char buf[32];
     if (addr < PCI_IO_SIZE) {
-        const char *r = reg[addr / 4];
+        const char *r = e100_reg[addr / 4];
         if (r != 0) {
             snprintf(buf, sizeof(buf), "%s+%u", r, addr % 4);
         } else {