diff mbox

drivers/net/irda/Kconfig: Let SH_IRDA depend on HAS_IOMEM

Message ID 542D6218.3040609@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Chen Gang Oct. 2, 2014, 2:32 p.m. UTC
SH_IRDA needs HAS_IOMEM, so depend on it. The related error(with
allmodconfig under um):

    CC [M]  drivers/net/irda/sh_irda.o
  drivers/net/irda/sh_irda.c: In function ‘sh_irda_probe’:
  drivers/net/irda/sh_irda.c:776:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
    self->membase = ioremap_nocache(res->start, resource_size(res));
    ^
  drivers/net/irda/sh_irda.c:776:16: warning: assignment makes pointer from integer without a cast [enabled by default]
    self->membase = ioremap_nocache(res->start, resource_size(res));
                  ^
  drivers/net/irda/sh_irda.c:821:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
    iounmap(self->membase);
    ^

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/net/irda/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Oct. 3, 2014, 10:52 p.m. UTC | #1
From: Chen Gang <gang.chen.5i5j@gmail.com>

Date: Thu, 02 Oct 2014 22:32:56 +0800

> SH_IRDA needs HAS_IOMEM, so depend on it. The related error(with

> allmodconfig under um):

> 

>     CC [M]  drivers/net/irda/sh_irda.o

>   drivers/net/irda/sh_irda.c: In function ‘sh_irda_probe’:

>   drivers/net/irda/sh_irda.c:776:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]

>     self->membase = ioremap_nocache(res->start, resource_size(res));

>     ^

>   drivers/net/irda/sh_irda.c:776:16: warning: assignment makes pointer from integer without a cast [enabled by default]

>     self->membase = ioremap_nocache(res->start, resource_size(res));

>                   ^

>   drivers/net/irda/sh_irda.c:821:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

>     iounmap(self->membase);

>     ^

> 

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>


Applied.
diff mbox

Patch

diff --git a/drivers/net/irda/Kconfig b/drivers/net/irda/Kconfig
index 8d101d6..a2c227b 100644
--- a/drivers/net/irda/Kconfig
+++ b/drivers/net/irda/Kconfig
@@ -397,7 +397,7 @@  config MCS_FIR
 config SH_IRDA
 	tristate "SuperH IrDA driver"
 	depends on IRDA
-	depends on ARCH_SHMOBILE || COMPILE_TEST
+	depends on (ARCH_SHMOBILE || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Say Y here if your want to enable SuperH IrDA devices.