diff mbox

[datapath,minor,fixes,2/3] datapath: avoid double free routing entry in vxlan_port xmit

Message ID 1412150148-9991-3-git-send-email-azhou@nicira.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Andy Zhou Oct. 1, 2014, 7:55 a.m. UTC 
Route entry will be free on error by vport when freeing skb.
additional error check and free after xmit() will cause double free.

Signed-off-by: Andy Zhou <azhou@nicira.com>
---
 datapath/vport-vxlan.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox

Patch

diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
index 8689853..44968d0 100644
--- a/datapath/vport-vxlan.c
+++ b/datapath/vport-vxlan.c
@@ -180,8 +180,6 @@  static int vxlan_tnl_send(struct vport *vport, struct sk_buff *skb)
 			     tun_key->ipv4_ttl, df,
 			     src_port, dst_port,
 			     htonl(be64_to_cpu(tun_key->tun_id) << 8));
-	if (err < 0)
-		ip_rt_put(rt);
 error:
 	return err;
 }