diff mbox

linux-next: build failure after merge of the net-next tree

Message ID 20141001170403.7a319458@canb.auug.org.au
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Stephen Rothwell Oct. 1, 2014, 7:04 a.m. UTC
Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
                      ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c: In function 'fm10k_set_ringparam':
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
  temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
  ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:12: warning: assignment makes pointer from integer without a cast
  temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
            ^
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:546:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(temp_ring);
  ^

Caused by commit 82dd0f7ee9a3 ("fm10k: Add ethtool support").  See Rule
1 in Documentation/SubmitChecklist.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Oct 2014 17:00:49 +1000
Subject: [PATCH] fm10k: using vmalloc requires including linux/vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kirsher, Jeffrey T Oct. 1, 2014, 7:29 a.m. UTC | #1
On Wed, 2014-10-01 at 17:04 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
> drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
>                       ^
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c: In function 'fm10k_set_ringparam':
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
>   temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
>   ^
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:477:12: warning: assignment makes pointer from integer without a cast
>   temp_ring = vmalloc(i * sizeof(struct fm10k_ring));
>             ^
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c:546:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(temp_ring);
>   ^
> 
> Caused by commit 82dd0f7ee9a3 ("fm10k: Add ethtool support").  See Rule
> 1 in Documentation/SubmitChecklist.
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 1 Oct 2014 17:00:49 +1000
> Subject: [PATCH] fm10k: using vmalloc requires including linux/vmalloc.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> index a9bbe60347d8..2d04464e6aa3 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> @@ -18,6 +18,8 @@
>   * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
>   */
>  
> +#include <linux/vmalloc.h>
> +
>  #include "fm10k.h"
>  
>  struct fm10k_stats {
> -- 
> 2.1.1
>
David Miller Oct. 1, 2014, 5:42 p.m. UTC | #2
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Oct 2014 17:04:03 +1000

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 1 Oct 2014 17:00:49 +1000
> Subject: [PATCH] fm10k: using vmalloc requires including linux/vmalloc.h
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
index a9bbe60347d8..2d04464e6aa3 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
@@ -18,6 +18,8 @@ 
  * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
  */
 
+#include <linux/vmalloc.h>
+
 #include "fm10k.h"
 
 struct fm10k_stats {