| Message ID | 1412029248-22454-3-git-send-email-richard@nod.at |
|---|---|
| State | Accepted |
| Headers | show |
On 9/30/2014 1:20 AM, Richard Weinberger wrote: > We need to add fm_sb too. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/fastmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 0431b46..2b0d8d6 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi) > { > size_t size; > > - size = sizeof(struct ubi_fm_hdr) + \ > + size = sizeof(struct ubi_fm_sb) + \ > + sizeof(struct ubi_fm_hdr) + \ > sizeof(struct ubi_fm_scan_pool) + \ > sizeof(struct ubi_fm_scan_pool) + \ > (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \ > Not sure what's the proper way doing this (Reviewed-by/Acked-by) but I agree this patch is required. I would just elaborate a bit more on the commit message. Thanks, Tanya Brokhman
Am 02.10.2014 15:14, schrieb Tanya Brokhman: > On 9/30/2014 1:20 AM, Richard Weinberger wrote: >> We need to add fm_sb too. >> >> Signed-off-by: Richard Weinberger <richard@nod.at> >> --- >> drivers/mtd/ubi/fastmap.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c >> index 0431b46..2b0d8d6 100644 >> --- a/drivers/mtd/ubi/fastmap.c >> +++ b/drivers/mtd/ubi/fastmap.c >> @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi) >> { >> size_t size; >> >> - size = sizeof(struct ubi_fm_hdr) + \ >> + size = sizeof(struct ubi_fm_sb) + \ >> + sizeof(struct ubi_fm_hdr) + \ >> sizeof(struct ubi_fm_scan_pool) + \ >> sizeof(struct ubi_fm_scan_pool) + \ >> (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \ >> > > Not sure what's the proper way doing this (Reviewed-by/Acked-by) but I agree this patch is required. I would just elaborate a bit more on the commit message. If you read this patch and find it good, please add your Reviewed-by. Thanks a lot for reviewing my patches! Thanks, //richard
On 9/30/2014 1:20 AM, Richard Weinberger wrote: > We need to add fm_sb too. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/fastmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 0431b46..2b0d8d6 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi) > { > size_t size; > > - size = sizeof(struct ubi_fm_hdr) + \ > + size = sizeof(struct ubi_fm_sb) + \ > + sizeof(struct ubi_fm_hdr) + \ > sizeof(struct ubi_fm_scan_pool) + \ > sizeof(struct ubi_fm_scan_pool) + \ > (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \ > Reviewed-by: Tanya Brokhman <tlinder@codeaurora.org>
On Tue, 2014-09-30 at 00:20 +0200, Richard Weinberger wrote: > We need to add fm_sb too. > > Signed-off-by: Richard Weinberger <richard@nod.at> Pushed this one, thank you!
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 0431b46..2b0d8d6 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi) { size_t size; - size = sizeof(struct ubi_fm_hdr) + \ + size = sizeof(struct ubi_fm_sb) + \ + sizeof(struct ubi_fm_hdr) + \ sizeof(struct ubi_fm_scan_pool) + \ sizeof(struct ubi_fm_scan_pool) + \ (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \
We need to add fm_sb too. Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/mtd/ubi/fastmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)